Skip to content
This repository has been archived by the owner on May 24, 2024. It is now read-only.

Updated paired result datasets and reflow logic to maintain consistency #222

Merged
merged 6 commits into from
Aug 30, 2021
Merged

Updated paired result datasets and reflow logic to maintain consistency #222

merged 6 commits into from
Aug 30, 2021

Conversation

AshishMotanamGurunadham
Copy link
Contributor

Summary

  • Updated paired result graph config objects, datasets and reflow logic in examples to maintain consistency.

Closes #211

Deployment Link

https://terra-graphs-deployed-pr-#.herokuapp.com/

Thank you for contributing to Terra.
@cerner/terra
@cerner/carbon

@mjhenkes mjhenkes temporarily deployed to terra-graphs-issue-211-xltgbof August 19, 2021 22:15 Inactive
@mjhenkes mjhenkes temporarily deployed to terra-graphs-issue-211-zmo6jtn August 20, 2021 21:15 Inactive
@mjhenkes mjhenkes temporarily deployed to terra-graphs-issue-211-zmo6jtn August 21, 2021 15:16 Inactive
@mjhenkes mjhenkes temporarily deployed to terra-graphs-issue-211-zmo6jtn August 21, 2021 15:32 Inactive
@sdadn
Copy link
Contributor

sdadn commented Aug 26, 2021

Did you update the react examples in the packages/terra-graphs-docs/src/terra-dev-site/doc/example/Graphs/PairedResultGraph folder?

@AshishMotanamGurunadham
Copy link
Contributor Author

Did you update the react examples in the packages/terra-graphs-docs/src/terra-dev-site/doc/example/Graphs/PairedResultGraph folder?

Yes Saad, You can see those from here.

@sdadn
Copy link
Contributor

sdadn commented Aug 30, 2021

nit:

  • 1-5: add pairedResult prefix for to the filenames for consistency
  • 6: update disable to disabled

CleanShot 2021-08-30 at 11 50 52@2x

@mjhenkes mjhenkes had a problem deploying to terra-graphs-issue-211-zmo6jtn August 30, 2021 17:38 Failure
@AshishMotanamGurunadham
Copy link
Contributor Author

AshishMotanamGurunadham commented Aug 30, 2021 •
edited
Loading

nit:

  • 1-5: add pairedResult prefix for to the filenames for consistency
  • 6: update disable to disabled

CleanShot 2021-08-30 at 11 50 52@2x

@sdadn Updated here.

@mjhenkes mjhenkes temporarily deployed to terra-graphs-issue-211-zmo6jtn August 30, 2021 18:17 Inactive
@AshishMotanamGurunadham AshishMotanamGurunadham merged commit 53cb99e into main Aug 30, 2021
@AshishMotanamGurunadham AshishMotanamGurunadham deleted the issue-211 branch August 30, 2021 19:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tbiethman tbiethman tbiethman approved these changes

@ryanthemanuel ryanthemanuel ryanthemanuel approved these changes

@sdadn sdadn sdadn approved these changes

@mjhenkes mjhenkes Awaiting requested review from mjhenkes

Assignees

@AshishMotanamGurunadham AshishMotanamGurunadham

Labels
chore Code cleanup and maintenance 📦 terra-graphs 📦 terra-graphs-docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update Paired Result graph example datasets and reflow logic to maintain consistency
5 participants
@AshishMotanamGurunadham @sdadn @tbiethman @ryanthemanuel @mjhenkes