This repository has been archived by the owner on May 24, 2024. It is now read-only.
Updated Pie charts example datasets to maintain consistency #217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AshishMotanamGurunadham
requested review from
mjhenkes,
ryanthemanuel and
tbiethman
as code owners
sdadn
reviewed
Aug 14, 2021
| import { loadPiePopup } from '@cerner/terra-graphs-docs/lib/example-datasets/popup'; | ||
|
|
||
| const dataset1 = { | ||
| key: 'uid_1', |
There was a problem hiding this comment.
nit: update key to reflect dataset e.g. simple_pie_data_1
There was a problem hiding this comment.
Fixed here.
tbiethman
approved these changes
Aug 16, 2021
ryanthemanuel
approved these changes
Aug 16, 2021
|
Can you add |
|
sdadn
reviewed
Aug 16, 2021
sdadn
approved these changes
Aug 16, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #212
Deployment Link
https://terra-graphs-deployed-pr-#.herokuapp.com/
Thank you for contributing to Terra.
@cerner/terra
@cerner/carbon