This repository has been archived by the owner on May 24, 2024. It is now read-only.
Update Scatter graphs documentation #249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdadn
requested review from
benbcai,
ryanthemanuel and
tbiethman
as code owners
ryanthemanuel
temporarily deployed
to
terra-graphs-issue-5470-lmzwy3
ryanthemanuel
temporarily deployed
to
terra-graphs-issue-5470-lmzwy3
ryanthemanuel
temporarily deployed
to
terra-graphs-issue-5470-lmzwy3
ryanthemanuel
temporarily deployed
to
terra-graphs-issue-5470-lmzwy3
ryanthemanuel
temporarily deployed
to
terra-graphs-issue-5470-lmzwy3
ryanthemanuel
temporarily deployed
to
terra-graphs-issue-5470-lmzwy3
ryanthemanuel
temporarily deployed
to
terra-graphs-issue-5470-lmzwy3
ryanthemanuel
temporarily deployed
to
terra-graphs-issue-5470-lmzwy3
ryanthemanuel
temporarily deployed
to
terra-graphs-issue-5470-lmzwy3
ryanthemanuel
temporarily deployed
to
terra-graphs-issue-5470-lmzwy3
benbcai
reviewed
Oct 21, 2021
| | Property Name | Type | Required | Default | Description | | ||
| |---------------|--------|----------|---------|--------------------------------------| | ||
| | x | string | yes | - | Value for the x coordinate. | | ||
| | y | string | yes | - | Value for the y coordinate. | |
There was a problem hiding this comment.
Should the Type for x and y be a number instead of string?
benbcai
approved these changes
Oct 21, 2021
ryanthemanuel
temporarily deployed
to
terra-graphs-issue-5470-lmzwy3
Comment on lines
190
to
200
| For a timeseries x-axis, the `type` of the x-axis config is set to `AXIS_TYPE.TIME_SERIES`: | ||
| ```js | ||
| // ... | ||
| axis: { | ||
| x: { | ||
| type: Carbon.helpers.AXIS_TYPE.TIME_SERIES | ||
| } | ||
| // ... | ||
| } | ||
| // ... | ||
| ``` |
There was a problem hiding this comment.
It would be better if we add this in graph doc instead of adding it near examples.
AshishMotanamGurunadham
approved these changes
Oct 22, 2021
ryanthemanuel
temporarily deployed
to
terra-graphs-issue-5470-lmzwy3
ryanthemanuel
temporarily deployed
to
terra-graphs-issue-5470-lmzwy3
ryanthemanuel
approved these changes
Oct 25, 2021
ryanthemanuel
temporarily deployed
to
terra-graphs-issue-5470-lmzwy3
ryanthemanuel
temporarily deployed
to
terra-graphs-issue-5470-lmzwy3
ryanthemanuel
temporarily deployed
to
terra-graphs-issue-5470-lmzwy3
ryanthemanuel
temporarily deployed
to
terra-graphs-issue-5470-lmzwy3
ryanthemanuel
pushed a commit
that referenced
this pull request
Nov 3, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #213
This PR closes two Jiras:
https://jira2.cerner.com/browse/UXPLATFORM-5470
https://jira2.cerner.com/browse/UXPLATFORM-5817
Deployment Link
https://terra-graphs-deployed-pr-#.herokuapp.com/
Testing
Additional Details
Thank you for contributing to Terra.
@cerner/terra
@cerner/carbon