This repository has been archived by the owner on May 24, 2024. It is now read-only.
Updated Timeline datasets and examples to maintain consistency. #231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AshishMotanamGurunadham
requested review from
mjhenkes,
ryanthemanuel and
tbiethman
as code owners
ryanthemanuel
approved these changes
Sep 10, 2021
sdadn
reviewed
Sep 10, 2021
Comment on lines
4
to
10
| const bobRossIpsum = "Just use the old one inch brush. It's so important to do something every day that will make you happy. " | ||
| + "I sincerely wish for you every possible joy life could bring. Water's like me. It's laaazy ... Boy, it " | ||
| + "always looks for the easiest way to do things\n\nWe're trying to teach you a technique here and how to use it. " | ||
| + 'The least little bit can do so much. There we go.\n\nNo worries. No cares. Just float and wait for the wind to blow you around. ' | ||
| + "These trees are so much fun. I get started on them and I have a hard time stopping. We'll make some happy little bushes here. " | ||
| + 'Absolutely no pressure. You are just a whisper floating across a mountain. There are no limits in this world. ' | ||
| + 'A thin paint will stick to a thick paint.\n'; |
There was a problem hiding this comment.
nit: use double quotes for all lines
There was a problem hiding this comment.
Fixed here.
sdadn
reviewed
Sep 10, 2021
Comment on lines
4
to
10
| const bobRossIpsum = "Just use the old one inch brush. It's so important to do something every day that will make you happy. " | ||
| + "I sincerely wish for you every possible joy life could bring. Water's like me. It's laaazy ... Boy, it " | ||
| + "always looks for the easiest way to do things\n\nWe're trying to teach you a technique here and how to use it. " | ||
| + 'The least little bit can do so much. There we go.\n\nNo worries. No cares. Just float and wait for the wind to blow you around. ' | ||
| + "These trees are so much fun. I get started on them and I have a hard time stopping. We'll make some happy little bushes here. " | ||
| + 'Absolutely no pressure. You are just a whisper floating across a mountain. There are no limits in this world. ' | ||
| + 'A thin paint will stick to a thick paint.\n'; |
There was a problem hiding this comment.
same nit: use double quotes for all lines
There was a problem hiding this comment.
Fixed here.
AshishMotanamGurunadham
force-pushed
the
issue-214
branch
from
621b6f6 to
be1e593
Compare
sdadn
reviewed
Sep 10, 2021
| import dataset1 from '@cerner/terra-graphs-docs/src/example-datasets/dataObjects/Timeline/defaultDataset1'; | ||
| import dataset2 from '@cerner/terra-graphs-docs/src/example-datasets/dataObjects/Timeline/defaultDataset2'; | ||
| import dynamicDataset1 from '@cerner/terra-graphs-docs/src/example-datasets/dataObjects/Timeline/criticalDataset1'; | ||
| import dynamicDataset2 from '@cerner/terra-graphs-docs/src/example-datasets/dataObjects/Timeline/criticalDataset2'; | ||
| import getTimelinePanningConfig from '@cerner/terra-graphs-docs/lib/example-datasets/graphConfigObjects/Timeline/timelinePanningConfig'; |
There was a problem hiding this comment.
nit: move this line above dataset imports
There was a problem hiding this comment.
Fixed here.
sdadn
approved these changes
Sep 10, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #214
JIRA LINK: https://jira2.cerner.com/browse/UXPLATFORM-5468
Deployment Link
https://terra-graphs-deployed-pr-#.herokuapp.com/
Thank you for contributing to Terra.
@cerner/terra
@cerner/carbon