You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When updating constraints.txt, importlib-metadata and mypy currently need to be pinned back for tests to continue to pass. I think this should ideally be fixed.
Also, importlib-metadata is only required by flake8 in Python < 3.8 so if you install josepy with pip using Python 3.8+, this package (and its dependency zipp) won't be included in the pip freeze output. I personally think it may be worth switching this repo to use something like poetry which better handles these cases. I think we could have a more traditional poetry setup here than what we current do in the Certbot repo. This is a larger project though.
The text was updated successfully, but these errors were encountered:
When updating
constraints.txt
,importlib-metadata
andmypy
currently need to be pinned back for tests to continue to pass. I think this should ideally be fixed.Also,
importlib-metadata
is only required by flake8 in Python < 3.8 so if you install josepy with pip using Python 3.8+, this package (and its dependencyzipp
) won't be included in thepip freeze
output. I personally think it may be worth switching this repo to use something likepoetry
which better handles these cases. I think we could have a more traditionalpoetry
setup here than what we current do in the Certbot repo. This is a larger project though.The text was updated successfully, but these errors were encountered: