Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LiveValue Feedback #24

Closed
jwise-mfg opened this issue Dec 16, 2024 · 5 comments
Closed

LiveValue Feedback #24

jwise-mfg opened this issue Dec 16, 2024 · 5 comments
Assignees
Labels
bug Something isn't working

Comments

@jwise-mfg
Copy link
Member

jwise-mfg commented Dec 16, 2024

Splitting out from #3

3.2.1 LiveValue
This is a nit pick, but 'Live' to me implies not cached/stale. I might change this to 'Latest'?

I'd love to remove the concept of 'quality' and just return data if we can vs. no data if it's bad with some way to get an error message back through the API on a failure. Quality to me is an OT legacy thing that isn't that useful outside of OT

The interpolation metadata seems odd? Remove it for LiveValue?

@jwise-mfg jwise-mfg changed the title LiveValue may be misleading name LiveValue Feedback Dec 16, 2024
@jwise-mfg
Copy link
Member Author

Copying in comments from Randy Armstrong on #3

The StatusCode in OPC UA is not the same as COM DA Quality. It is an error code indicating the reason for the Bad data. I think Quality should just be called 'Status' or 'StatusCode'

Returning metadata with a value is a convenience that comes with significant cost. Clients that know what they asked for do not need it so there should be an option available to only return values.

@jwise-mfg
Copy link
Member Author

Copying in comments from Scott Wyant on #15

Callers may mistakenly make assumptions on QUALITY of the value when using an interface of "LiveValue".
Calling an interface of "LatestValue" leads you right into considering the "quality" of the data.

@matthewGEA
Copy link
Contributor

I concur that "LiveValue" should be renamed as it's not clear whether the data is provided after a request or unsolicited through subscription.

I propose renaming the endpoint to "READ" to clarify that the intention of the endpoint is for the client to request a read of an endpoint and the server will respond with the latest value that it has.

@jwise-mfg
Copy link
Member Author

Consensus is that this should be LastKnownValue (LKV). Will update doc.

@jwise-mfg jwise-mfg self-assigned this Jan 14, 2025
@jwise-mfg jwise-mfg added the bug Something isn't working label Jan 14, 2025
@jwise-mfg
Copy link
Member Author

We think TimeStamp should probably be required metadata for a LKV -- but the Q in QVT (Quality Value Time) is still being discussed here: #27

jwise-mfg added a commit that referenced this issue Jan 14, 2025
oliviamorales added a commit that referenced this issue Jan 14, 2025
Naming and textual changes from Working Group meeting on 01/14/2025, issues  #14, #24, #31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants