Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor badge-maker node version to support e2e testing for logos/links #2

Open
cgbur opened this issue Jan 10, 2021 · 0 comments
Open

Refactor badge-maker node version to support e2e testing for logos/links #2

cgbur opened this issue Jan 10, 2021 · 0 comments
Labels
code coverage Issue concerning code coverage and testing

Comments

@cgbur
Copy link
Owner

cgbur commented Jan 10, 2021 •
edited
Loading

Currently the npm module has the logos and links rendering behind an API call so you cannot access them. This is probably because on shields.io logos and links are handled another way? Not sure but need to refactor the JS code they have to make the private API the public one. Then it can be integrated into the tests/e2e.rs we already have.
@cgbur cgbur added the code coverage Issue concerning code coverage and testing label Jan 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
code coverage Issue concerning code coverage and testing
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@cgbur