Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JOSE] Jose Paper #19

Open
BenjMy opened this issue Dec 19, 2022 · 5 comments
Open

[JOSE] Jose Paper #19

BenjMy opened this issue Dec 19, 2022 · 5 comments
Labels

Comments

@BenjMy
Copy link

BenjMy commented Dec 19, 2022

xref openjournals/jose-reviews#185

Overall it is good start, but reads a bit choppy. I found the article very ressource exploitation (oil, mining, ...) target-oriented while I think this tools has many other disciplines to reach.

  • Statement of needs

    • To me for instance the tools developed can be also associated with environmental risks management (water scarcity, landslides, ...). I am personnaly interested to this package for Catchement hydrologeology modelling. Authors should broaden this idea in the statement of needs.

    • I like the proof of concept and that authors already used the software for teaching to RWTH Aachen. Could it be possible to add (in the "Experience of use in teaching and learning situations" section):

      • a link to the degree where it has been tought;
      • the number of hours dedicated to the course (and how it has been distributed over all the notebooks);
      • the ratio between the number of instructors and number of students.
    • "Even from seismic data" is to me again to me to narrow. Why other geophysical approaches able to infer geological structures (TEM, gravity, ...) are not considered?

  • Ressources:

  • References:
    Seems that references are broken in the paper compilation.

@jwagemann
Copy link

Hi. I am adding additional comments to each issue @BenjMy already started.

  • References in the paper seem not to be properly rendered
  • Statement of Need needs refinement and need to be clearer
    • What does ‘paper-based analog approach’ mean?
    • I think the scope and target audience can be a bit broader as I see value in the tutorial being of interest for everyone who is interested in using the two open-source packages GemGIS and GemPy
  • Make sure to spell out acronyms - e.g. what are ‘AR-sandboxes’?
  • you claim that the material can easily be used by other instructors. However, I doubt that this is the case at the moment. I would suggest to make the notebooks more educational and self-explanatory
  • From the paper, it is currently hard to follow and grasp the structure and organisation of the course - this is also due to the fact that the course itself can be restructured. See my comment here

@AlexanderJuestel
Copy link
Collaborator

AlexanderJuestel commented Jan 15, 2023

But here also a list to track my progress:

  • Statement of needs

  • To me for instance the tools developed can be also associated with environmental risks management (water scarcity, landslides, ...). I am personnaly interested to this package for Catchement hydrologeology modelling. Authors should broaden this idea in the statement of needs. --> This also relates to [JOSE] Applications of structural models created with GemPy #23

  • I like the proof of concept and that authors already used the software for teaching to RWTH Aachen. Could it be possible to add (in the "Experience of use in teaching and learning situations" section):

      - a link to the degree where it has been tought;
      - the number of hours dedicated to the course (and how it has been distributed over all the notebooks);
      - the ratio between the number of instructors and number of students.
    
  • "Even from seismic data" is to me again to me to narrow. Why other geophysical approaches able to infer geological structures (TEM, gravity, ...) are not considered?

    • Ressources:
  • I suggest to change the order of ressources and place "GemGIS" first and then add "GemPy" indicating that it is an optionnal dependency.

  • "Tutorial repository" link and "GemGIS link" are redundant. Choose one or another or change the first to "https://gemgis.readthedocs.io/en/latest/getting_started/tutorial/index.html"

    • References:
  • Seems that references are broken in the paper compilation. --> The references compile using Github Actions in the gemgis_data repo

  • Statement of Need needs refinement and need to be clearer

    • What does ‘paper-based analog approach’ mean? --> A sentence was added to explain it better (0e31368)
    • I think the scope and target audience can be a bit broader as I see value in the tutorial being of interest for everyone who is interested in using the two open-source packages GemGIS and GemPy --> A sentence was added that GemGIS can also be used without GemPy which makes GemGIS also attractive to other fields and not only to the structural geological modeling with GemPy (3055e16)
  • Make sure to spell out acronyms - e.g. what are ‘AR-sandboxes’? --> The AR acronym has been spelled out

  • you claim that the material can easily be used by other instructors. However, I doubt that this is the case at the moment. I would suggest to make the notebooks more educational and self-explanatory --> The notebooks were completely overhauled

  • From the paper, it is currently hard to follow and grasp the structure and organisation of the course - this is also due to the fact that the course itself can be restructured. See my comment here --> Changes made to the notebooks are addressed in [JOSE] Pedagogy / Instructional design #18

@BenjMy
Copy link
Author

BenjMy commented Feb 17, 2023

Hi @AlexanderJuestel,

Thanks for taking into consideration all my comments. Nothing the add here from my side.

@AlexanderJuestel
Copy link
Collaborator

@BenjMy, thanks for that! I think I forgot to go over @jwagemann comments here. I will add them to my list above and will go through them right away

@AlexanderJuestel
Copy link
Collaborator

@jwagemann I tried to add some information to the manuscript based on your comments. Please feel free to review the changes and let me know if I can close this issue here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants