Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli): support Prysm keystores #689

Open
merklefruit opened this issue Jan 17, 2025 · 2 comments
Open

feat(cli): support Prysm keystores #689

merklefruit opened this issue Jan 17, 2025 · 2 comments
Labels
C: bolt-cli Component: bolt CLI T: feature Type: Feature
Milestone

Comments

@merklefruit
Copy link
Collaborator

Describe the feature

bolt pubkeys local-keystore and bolt delegate local-keystore commands don't currently support Prysm keystores.
We should add support for them as part of our push to increase client compatibility.

Additional context

No response

@merklefruit merklefruit added C: bolt-cli Component: bolt CLI T: feature Type: Feature labels Jan 17, 2025
@merklefruit merklefruit added this to the v0.4.1 milestone Jan 17, 2025
@mempirate mempirate modified the milestones: v0.4.1, v0.5 Jan 29, 2025
@0ex-d
Copy link
Contributor

0ex-d commented Feb 5, 2025

Preamble:

# current command
bolt pubkeys local-keystore --path test_data/lighthouse/validators
# or
bolt pubkeys local-keystore --path test_data/prysm/direct
  1. we could accommodate by checking heuristics like pubkey not available in prysm but looks hacky or
  2. change to below to specifically load keystores based on CL clients.
# proposed
bolt pubkeys local-keystore --client prysm --path test_data/prysm/direct 

The current implementation (lighthouse client only), loads keystores from bolt-cli/test_data/lighthouse/validators/0x8a../voting-keystore.json.

To implement prysm for example in bolt-cli/test_data/prysm/direct/accounts/all-accounts.keystore.json I believe there has to be a way to distinguish what keystore is being used because of the a few differences in the json data structure.

Let me know what you think.

@0ex-d
Copy link
Contributor

0ex-d commented Feb 14, 2025

@merklefruit can you please weigh in on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: bolt-cli Component: bolt CLI T: feature Type: Feature
Projects
None yet
Development

No branches or pull requests

3 participants