Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(guides): don't use quotes for single-word extradata #748

Closed
wants to merge 1 commit into from

Conversation

merklefruit
Copy link
Collaborator

@merklefruit merklefruit commented Jan 29, 2025

An operator incurred into this issue and registered twice for this reason

@merklefruit
Copy link
Collaborator Author

📚 $\text{Stack Overview}$

Pulls submitted in this stack:

This comment was automatically generated by st.

@merklefruit merklefruit changed the title fix(guides): don't use quotes for single-word extradata" fix(guides): don't use quotes for single-word extradata Jan 29, 2025
Comment on lines +103 to +104
such as your operator name, website or a custom identifier. If you use a single word, please
avoid using quotes (e.g. `my-operator` instead of `"my-operator"`).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some questions:

  • can't we strip away " on the bolt CLI instead?
  • I think "word" might be a little ambiguous since I don't consider a URL a word. Maybe you were referring about the presence of whitespaces
  • can you make more examples of what is the on-chain result based on the input?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants