Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Seq fails in v14dev #176

Open
micoloth opened this issue Oct 2, 2024 · 2 comments
Open

Seq fails in v14dev #176

micoloth opened this issue Oct 2, 2024 · 2 comments

Comments

@micoloth
Copy link

micoloth commented Oct 2, 2024

First of all I love all the refactoring you did @itsjunetime , the code is very clean 🙌🏼

At this moment, at tag 14dev the Seq node doesn't work: all the notes are triggered together at the start of the bar, instead of being played in sequence.

How to reproduce:

  • Go to tag 13.5
  • Compile
  • Play this: o: seq 33 __ __ 33 36 33 36 33 28 __ __ 28 31 28 31 __ >> bd 0.2 -> you hear it correctly
  • Go to tag 14dev
  • Compile
  • Play the same -> you only hear 1 beat per bar

IMPORTANT NOTE: I'm using the Glicol-cli to hear the music. (compiling Glicol-cli by pointing it to my local clone of Glicol) So the problem might be a compatibility problem between the 2 Repos. ( I fixed a few Return type errors already)

I would be available to open a PR with a fix, if somebody can help me figure out where to look 👀

@chaosprint
Copy link
Owner

@micoloth
Copy link
Author

micoloth commented Dec 25, 2024

I got down to fix this problem

My PR here restores the original behaviour:

https://github.com/chaosprint/glicol/pull/181/files

I don't know @itsjunetime if there was a reason for this breaking change. Was it intentional / should it be integrated in some other way?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants