Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev release to Main #2699

Closed
wants to merge 16 commits into from
Closed

Dev release to Main #2699

wants to merge 16 commits into from

Conversation

sgoggins
Copy link
Member

Description

  • Improvements to user profile UI
  • Small bug fixes

Ulincsys and others added 16 commits August 12, 2023 17:24
Signed-off-by: Ulincsys <[email protected]>
Signed-off-by: Ulincsys <[email protected]>
… others that self resolve based on an end users version of Python3 now.

Signed-off-by: sgoggins <[email protected]>
- Add ability to pass flags to `augur backend start` in compose
- Add entrypoint for `AUGUR_TARGET=graphical`
- Fix metadata import in compose environment
- Improve Docker compatibility with startup wizard

Signed-off-by: Ulincsys <[email protected]>
Signed-off-by: Ulincsys <[email protected]>
Signed-off-by: Isaac Milarsky <[email protected]>
Update Dev with Changes to Main
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

pylint

scripts/install/wizard.py|200 col 14| R1732: Consider using 'with' for resource-allocating operations (consider-using-with)
scripts/install/wizard.py|224 col 8| W0601: Global variable 'do_continue' undefined at the module level (global-variable-undefined)
scripts/install/wizard.py|58| R0915: Too many statements (83/50) (too-many-statements)
scripts/install/wizard.py|88 col 4| W0612: Unused variable 'all_in' (unused-variable)
scripts/install/wizard.py|239 col 4| W0612: Unused variable 'e' (unused-variable)
scripts/install/wizard.py|266 col 4| W0604: Using the global statement at the module level (global-at-module-level)
scripts/install/wizard.py|272 col 12| R1732: Consider using 'with' for resource-allocating operations (consider-using-with)
scripts/install/wizard.py|4| C0412: Imports from package sqlalchemy are not grouped (ungrouped-imports)
scripts/install/wizard.py|269 col 20| R1732: Consider using 'with' for resource-allocating operations (consider-using-with)

@@ -1,12 +1,9 @@
from pathlib import Path

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[pylint] reported by reviewdog 🐶
C0114: Missing module docstring (missing-module-docstring)

@@ -1,12 +1,9 @@
from pathlib import Path
from .server import Environment
from augur.application.logs import AugurLogger
import logging, secrets, yaml

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[pylint] reported by reviewdog 🐶
C0410: Multiple imports on one line (logging, secrets, yaml) (multiple-imports)

@@ -1,3 +1 @@
from .Environment import Environment
from .ServerThread import ServerThread
from .LoginException import LoginException

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[pylint] reported by reviewdog 🐶
C0114: Missing module docstring (missing-module-docstring)

@@ -32,7 +34,7 @@ def cli():
@test_connection
@test_db_connection
def init_config(github_api_key, facade_repo_directory, gitlab_api_key, redis_conn_string, rabbitmq_conn_string):

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[pylint] reported by reviewdog 🐶
C0116: Missing function or method docstring (missing-function-docstring)

@@ -155,13 +157,19 @@
@click.option('--section', required=True)
@click.option('--setting', required=True)
@click.option('--value', required=True)
@click.option('--data-type', required=True)
@click.option('--data-type')
@test_connection
@test_db_connection
def config_set(section, setting, value, data_type):

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[pylint] reported by reviewdog 🐶
C0116: Missing function or method docstring (missing-function-docstring)

@app.route("/db/version")
@requires_key
def version_db():
out = subprocess.Popen("augur db print-db-version".split(), text=True, stderr=subprocess.PIPE, stdout=subprocess.PIPE)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[pylint] reported by reviewdog 🐶
R1732: Consider using 'with' for resource-allocating operations (consider-using-with)

@app.route("/db/versions/list")
@requires_key
def versions_db():
out = subprocess.Popen("augur db check-for-upgrade".split(), text=True, stderr=subprocess.PIPE, stdout=subprocess.PIPE)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[pylint] reported by reviewdog 🐶
R1732: Consider using 'with' for resource-allocating operations (consider-using-with)

def update_config_db():
data = request.get_json()

result = subprocess.Popen("augur db create-schema".split(), stdout=subprocess.PIPE, stderr=subprocess.PIPE)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[pylint] reported by reviewdog 🐶
R1732: Consider using 'with' for resource-allocating operations (consider-using-with)

result = subprocess.Popen(f"{config_script}", stdout=subprocess.PIPE, stderr=subprocess.PIPE)
try:
result.wait(10)
except:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[pylint] reported by reviewdog 🐶
W0702: No exception type(s) specified (bare-except)


for key, value in data.items():
env[key] = value
result = subprocess.Popen(f"{config_script}", stdout=subprocess.PIPE, stderr=subprocess.PIPE)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[pylint] reported by reviewdog 🐶
R1732: Consider using 'with' for resource-allocating operations (consider-using-with)

@sgoggins sgoggins closed this Feb 20, 2024
@sgoggins sgoggins deleted the dev branch February 20, 2024 01:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants