Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When dynamically adding and deleting pins some pins get re-copied #50

Closed
dnasello opened this issue Aug 4, 2014 · 10 comments
Closed

When dynamically adding and deleting pins some pins get re-copied #50

dnasello opened this issue Aug 4, 2014 · 10 comments

Comments

@dnasello
Copy link

dnasello commented Aug 4, 2014

For instance:
If I add 100 annotations in NJ. then I move to PA and add new pins (and still leaving the pins in nj). Then scroll back to the pins in jersey they seem to "double", meaning there are two annotations in the place of one for whatever reason in the same geo (note I do not fetch for more pins).

@dnasello
Copy link
Author

dnasello commented Aug 4, 2014

After further investigation, for some reason the tree is adding "multiple" annotations grouped as one and isOneLocation returns true on them. The only reason why I care is because I do not want the pins to "flash" when getting more.

@choefele
Copy link
Owner

choefele commented Aug 4, 2014

I haven't seen this problem before. Could you please provide a project that demonstrates this problem and that I can use to debug this issue?

@choefele
Copy link
Owner

Please re-open when you have a sample project that demonstrates this problem and I'll have a look – thanks

@dnasello
Copy link
Author

Sorry, I do not use git every day. The problem is as follows. The tree that is being created as a cluster stays even if the pins that re clustered in that cluster are being removed from the map. I will make an exact demonstration. Other than than I absolutely love what you did I think it is quite extraordinary. Just out of curiousity, how many pins could one have on the map? IE I might wind up having 50k or so.. should I just get all pins at once?

@choefele choefele reopened this Aug 22, 2014
@choefele
Copy link
Owner

Yes, please provide a demo project so I can have a look at the problem. When you call removeAnnotations:withCompletionHandler:, the clusters should be updated automatically.

@dnasello
Copy link
Author

Great. Also is there a way I can change the fade animation? IE I would rather it slide to the cluster as I am doing something a bit different than the example. I see where the animator class is however it does not expose the x,y changes on the map other wise I would just use the @slide animations.

Thank you again.

Also, here is my app that uses your plugin.....

https://itunes.apple.com/us/app/pinstant-anonymous-stories/id903451658?mt=8

I released an update a few days ago that fixes some pin issues I had but the pin grouping works quite well.

@choefele
Copy link
Owner

Great job on the app!

I believe your request for animation is the same as issue #10. It's on my list to implement, but I haven't had the time yet.

@dnasello
Copy link
Author

dnasello commented Sep 2, 2014

That is exactly what I am looking for. Can my company donate to the project anywhere?

@choefele
Copy link
Owner

choefele commented Sep 2, 2014

Unfortunately, I won't have time to look into this until end of October. If that suits your time frame, let me know.

@choefele
Copy link
Owner

Thanks for your feedback. I think this issue can be closed, but feel free to open another issue if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants