Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Babel 7 support #523

Open
johncalvinroberts opened this issue Apr 4, 2019 · 2 comments
Open

Babel 7 support #523

johncalvinroberts opened this issue Apr 4, 2019 · 2 comments

Comments

@johncalvinroberts
Copy link

johncalvinroberts commented Apr 4, 2019

a 🙋 feature request

Just tried firing up a new bankai this morning and ran into some issues when configuring babel presets.

Expected Behavior

Can install babel 7 @babel/core and other babel presets + plugins for babel 7

Current Behavior

When running bankai start index.js, it threw error:

scripts:browserify.bundle Requires Babel "^7.0.0-0", but was loaded with "6.26.3". If you are sure you have a compatible version of @babel/core, it is likely that something in your build process is loading the wrong version. Inspect the stack trace of this error to look for the first entry that doesn't mention "@babel/core" or "babel-core" to see what is calling Babel.

Code Sample

(from package.json)

{
 ...
  "browserify": {
    "transform": [
        ["babelify", {"presets": ["@babel/preset-env", "@babel/preset-react"]}]
    ]
  }
 ...
}
Software Version(s)
Package [email protected]
Runtime node 10.6.0
Package Manager npm
Operating System macos 10.12.6

Thanks in advance! Bankai is cool :)

@goto-bus-stop
Copy link
Member

goto-bus-stop commented Apr 4, 2019

yeah, bankai includes babel by default, and is currently still using v6 :(

switching to v7 is 'planned' for bankai v10, but it's unclear when that'll be ready.

e; are you installing babelify manually as well, and if so which version? bankai includes one, but it's one for babel v6.

@johncalvinroberts
Copy link
Author

Hi! Not installing babelify manually -- just using bankai default, 8.x.x can't remember the exact version, bankai's dependency. I tried installing from branch babel-7, seems to work (somewhat) but maybe some issues. Is it supposed to be transpiling node_modules?

Anything I could do to help?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants