Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI option -port not working #84

Closed
mainiak opened this issue Jun 11, 2021 · 2 comments
Closed

CLI option -port not working #84

mainiak opened this issue Jun 11, 2021 · 2 comments
Labels

Comments

@mainiak
Copy link

mainiak commented Jun 11, 2021

Hello.

I tested against current (literally) latest docker image (no version?) and previous 1.4.1 and when provided ie. -port 9000 doesn't work.

I tried to change order how I provide arguments, but order of arguments wasn't the reason. Other CLI (-config, -queries, -service) work.

I tried even looking at source code and there doesn't seem anything wrong with it.

/bin/docker run \
--rm \
--name prometheus_sql \
-p 9000:9000 \
-v /data/prometheus_sql:/data \
dbhi/prometheus-sql:1.4.1 \
-port 9000 \
-config /data/config.yml \
-queries /data/queries.yml \
-service http://sqlagent:5000

^^^ Doesn't work

I found workaround by providing -e PROMSQL_PORT=9000 to docker run.

Because of the work around it is not any high priority issue, but wanted to report anyway.

@mainiak
Copy link
Author

mainiak commented Jun 11, 2021

Might be because how entrypoint works in docker image ...

🤔

@haxorof
Copy link
Contributor

haxorof commented Jun 12, 2021

Thanks for reporting. Will fix

@haxorof haxorof added the bug label Jun 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants