[Bug]: JS client - getCollection requires the embedding function as a param

[rohanprichard]

What happened?

Just wanted to discuss something I had noticed while using chroma with the JS client.

When you call client.createCollection or client.getOrCreateCollection, the type CreateCollectionParams is used. This has name as a required parameter, and metadata and embedding function as optional ones.

type CreateCollectionParams = {
  name: string;
  metadata?: CollectionMetadata;
  embeddingFunction?: IEmbeddingFunction;
};

type GetOrCreateCollectionParams = CreateCollectionParams;

However, for client.getCollection, the type GetCollectionParams is used. This has the name as well as embedding function as a required parameter. Even if using the default embedding function, this is what is seen.

GetCollectionParams = {
  name: string;
  embeddingFunction: IEmbeddingFunction;
};

These snippets are from chroma/clients/js/src/types.ts

After looking around in the source code, I have not been able to figure out why it is made required, so wanted to log it as a possible bug.

If this is all a mistake on my part I am sorry, but just wanted to log something I had noticed. Let me know if I can make a fix and contribute to this!

Versions

chromadb 1.10.4, python 3.9, macos 15.3

Relevant log output