Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ENH] Spann works e2e on local tilt #3944

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

[ENH] Spann works e2e on local tilt #3944

wants to merge 4 commits into from

Conversation

sanketkedia
Copy link
Contributor

@sanketkedia sanketkedia commented Mar 9, 2025 •
edited
Loading

Description of changes

Summarize the changes made by this PR.

  • Improvements & Bug fixes
    • Plumbs config in the collection and segment metadata that identifies spann segment
    • Uses this information to appropriately construct readers/writers wherever needed
    • Note that it only does so for the rust frontend
    • Fixes other issues in the write and read path
    • Note: this feature is only available on Rust Frontend currently
  • New functionality
    • ...

Test plan

How are these changes tested?

  • Tests pass locally with pytest for python, yarn test for js, cargo test for rust

Documentation Changes

None

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 9, 2025

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

@sanketkedia Graphite App
Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@sanketkedia sanketkedia requested a review from HammadB March 9, 2025 02:33
@sanketkedia sanketkedia marked this pull request as ready for review March 9, 2025 02:33
@sanketkedia sanketkedia force-pushed the 03-08-_enh_towards_enabling_spann_in_staging branch from f96f33f to 2a0ec9c Compare March 9, 2025 21:43
@sanketkedia sanketkedia changed the title [ENH] Towards enabling spann in staging [ENH] Spann works e2e on local tilt Mar 10, 2025
HammadB
HammadB reviewed Mar 10, 2025
View reviewed changes
rust/frontend/src/frontend.rs
file_path: Default::default(),
}
}
DistributedIndexType::Spann => {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to add some feature gating here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HammadB HammadB HammadB left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sanketkedia @HammadB