Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use tauri v2 #398

Open
fossdd opened this issue Dec 21, 2024 · 6 comments · May be fixed by #412
Open

Use tauri v2 #398

fossdd opened this issue Dec 21, 2024 · 6 comments · May be fixed by #412

Comments

@fossdd
Copy link

fossdd commented Dec 21, 2024

Describe the problem

tauri v1 (which is currently used by cinny) uses webkit2gtk 4.0. However webkit2gtk 4.0 is outdated and unavailable on many distribitions like Debian or Alpine (which I was packaging Cinny on).

Unfortunaly I have to disable the cinny package on Alpine Linux since we removed webkit2gtk 4.0 and only support webkit2gtk 4.1 or 6.0.

See also #367 or tauri-apps/tauri#9662

Describe the solution you'd like

Ideally cinny-desktop could be moved to tauri v2 which supports webkit2gtk 4.1 and would restore support for many distributions.

Alternatives considered

No response

Additional context

No response

@Neved4
Copy link

Neved4 commented Jan 14, 2025

I like this idea!

Could be done by using the commands from Upgrade from Tauri 1.0 | Automated Migration.

We'll need to remember to upgrade our plugins under Cargo.toml.

@Neved4
Copy link

Neved4 commented Jan 17, 2025

For reference this is currently blocking #247, cinnyapp/cinny#446

I'll take care of those when we upgrade cinny-desktop

@Neved4
Copy link

Neved4 commented Jan 21, 2025

Gave it a try, and attempted to migrate tauri v1 to v2.

Pulled off the right dependencies, and tauri.conf.json had to undergo some modifications for v2. Eventually hit a block, since the migration produces numerous Rust errors. Couldn't seem to solve all of them. Clearly this is going to take much longer for me to address.

Overall learned some things, but can't do it yet on my own. Could set an initial PR, but would be broken atm.

Any help would be awesome.

@fossdd
Copy link
Author

fossdd commented Jan 21, 2025 via email

@kfiven
Copy link
Collaborator

kfiven commented Jan 21, 2025

@Neved4 I also had similar rust issues. Same, thought this would be easy task but turned out to be much complicated. For a reference you could find some other other projects that migrated to v2.

@bengaywins bengaywins linked a pull request Jan 28, 2025 that will close this issue
9 tasks
@bengaywins
Copy link

My first rust project contribution, but the above linked PR was able to build on both WSL and Arch. I am just a lowly ops dude, so maybe the small changes to the main.rs aren't correct (for some reason I don't understand), but it at least worked when I was using the updated client under testing last night.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants