Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing <th> on admin form tables #2941

Open
rachidatecs opened this issue Oct 15, 2024 · 2 comments · May be fixed by #3071
Open

Missing <th> on admin form tables #2941

rachidatecs opened this issue Oct 15, 2024 · 2 comments · May be fixed by #3071
Assignees
@rachidatecs
Labels
accessibility bug Something that isn't working as intended dev Feature: 🧮 Analyst Experience

Comments

@rachidatecs
Copy link
Contributor

rachidatecs commented Oct 15, 2024 •
edited
Loading

Current Behavior

The custom tables we're using throughout DJA for contacts feature a 'copy email' column on the right. That column 's <td>s do not have any associated <th>.

Expected Behavior

Every <td> should have an associated <th> either in the THEAD or as the first table cell in its row.

Per this slack discussion, we should have a visible <th> that says ‘Action’

This should be applied to every instance of DJA table that features a 'copy email' button.

Steps to Reproduce

  1. Navigate to a domain request with other contacts or portfolio with members and admins.
  2. Inspect table.

Environment

No response

Additional Context

No response

Issue Links

No response

Prioritization Comments

WCAG Conformance Level:
WCAG Standard that applies:
Critical Failure if Not Met?:
Prioritization:
Reason:
@rachidatecs rachidatecs added accessibility bug Something that isn't working as intended labels Oct 15, 2024
@abroddrick abroddrick moved this from 👶 New to 🍦 Backlog in .gov Product Board Oct 15, 2024
@abroddrick abroddrick moved this from 🍦 Backlog to 🎯 Ready in .gov Product Board Oct 15, 2024
@abroddrick
Copy link
Contributor

abroddrick commented Oct 15, 2024 •
edited
Loading

Soft sprinting for 57, just because it's a nice easy ticket that shouldn't take a ton of time. Adding analyst experience, though it's mostly an accessibility thing.

@h-m-f-t h-m-f-t changed the title Missing TH on admin form tables Missing <th> on admin form tables Nov 8, 2024
@rachidatecs rachidatecs self-assigned this Nov 12, 2024
@vickyszuchin vickyszuchin moved this from 🎯 Ready to 🔖 Planned in .gov Product Board Nov 12, 2024
@rachidatecs rachidatecs linked a pull request Nov 13, 2024 that will close this issue
Open
32 tasks
@rachidatecs rachidatecs moved this from 🔖 Planned to 👀 In review in .gov Product Board Nov 13, 2024
@SamiyahKey
Copy link

I have completed the Design Review for this issue 3071, it looks great and passes all acceptance criteria!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rachidatecs rachidatecs

Labels
accessibility bug Something that isn't working as intended dev Feature: 🧮 Analyst Experience
Projects
.gov Product Board
Status: 👀 In review
Milestone
No milestone
4 participants
@rachidatecs @abroddrick @vickyszuchin @SamiyahKey