Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix journalAbbr suffix in elsevier #6825

Conversation

northword
Copy link
Contributor

@northword northword commented Dec 29, 2023

Elsevier's journals no longer have the suffix . after the publicationTitle in the reference list.

My reviewer's comment:

image

example:

  1. Applied Catalyst B: Enviroment (elsevier): https://www.sciencedirect.com/science/article/pii/S0926337323012493

    image

  2. Journal of Catalysis (elsevier):
    https://www.sciencedirect.com/science/article/pii/S0021951723004992

    image

    image

Copy link

Awesome! You just created a pull request to the Citation Styles Language styles repository. One of our human volunteers will try to get in touch soon (usually within a week). In the meantime, I will run some automated checks. You should be notified of the results in a few minutes.

If you haven't done so yet, please make sure your style validates and follows all our other Style Requirements.

To update this pull request, visit the "Files changed" tab above, click on the ellipsis button in the top-right corner of your style, and then select "Edit file" to start editing:

If you have any questions, please leave a comment and we'll get back to you. While we usually respond in English, feel free to write in whatever language you're most comfortable.

Copy link

😃 Your submission passed all our automated tests.

Below are some sample citations generated based on your proposed changes:

elsevier-with-titles.csl (modified style)
[1,2]
[3,4]

[1]B. Hancké, M. Rhodes, M. Thatcher, eds., Beyond varieties of capitalism: Conflict, contradiction, and complementarities in the European economy, Oxford University Press, Oxford and New York, 2007.
[2]CSL search by example, Citation Style Editor (2012). http://editor.citationstyles.org/searchByExample/ (accessed December 15, 2012).
[3]I. Mares, Firms and the welfare state: When, why, and how does social policy matter to employers?, in: P.A. Hall, D. Soskice (Eds.), Varieties of Capitalism. The Institutional Foundations of Comparative Advantage, Oxford University Press, New York, 2001: pp. 184–213.
[4]M. Fenner, M. Crosas, J.S. Grethe, D. Kennedy, H. Hermjakob, P. Rocca-Serra, G. Durand, R. Berjon, S. Karcher, M. Martone, T. Clark, A data citation roadmap for scholarly data repositories, Sci. Data 6 (2019) 28. https://doi.org/10.1038/s41597-019-0031-8.
 [1,2]<br/>
 [3,4]<br/>
 <hr/>
 [1]B. Hancké, M. Rhodes, M. Thatcher, eds., Beyond varieties of capitalism: Conflict, contradiction, and complementarities in the European economy, Oxford University Press, Oxford and New York, 2007.<br/>
-[2]CSL search by example, Citation Style Editor. (2012). http://editor.citationstyles.org/searchByExample/ (accessed December 15, 2012).<br/>
+[2]CSL search by example, Citation Style Editor (2012). http://editor.citationstyles.org/searchByExample/ (accessed December 15, 2012).<br/>
 [3]I. Mares, Firms and the welfare state: When, why, and how does social policy matter to employers?, in: P.A. Hall, D. Soskice (Eds.), Varieties of Capitalism. The Institutional Foundations of Comparative Advantage, Oxford University Press, New York, 2001: pp. 184–213.<br/>
-[4]M. Fenner, M. Crosas, J.S. Grethe, D. Kennedy, H. Hermjakob, P. Rocca-Serra, G. Durand, R. Berjon, S. Karcher, M. Martone, T. Clark, A data citation roadmap for scholarly data repositories, Sci. Data. 6 (2019) 28. https://doi.org/10.1038/s41597-019-0031-8.<br/>
+[4]M. Fenner, M. Crosas, J.S. Grethe, D. Kennedy, H. Hermjakob, P. Rocca-Serra, G. Durand, R. Berjon, S. Karcher, M. Martone, T. Clark, A data citation roadmap for scholarly data repositories, Sci. Data 6 (2019) 28. https://doi.org/10.1038/s41597-019-0031-8.<br/>

@bwiernik
Copy link
Member

Thanks! Could you make the same change to elsevier-with-titles-alphabetical.csl and elsevier-without-titles.csl?

@github-actions github-actions bot added the waiting-for-response-from-contributor The ticket/pull request is awaiting input from the contributor/depositor label Dec 29, 2023
@adam3smith
Copy link
Member

Hmm -- but note in the actual instructions for authors for Applied Catalysis B

image

Do we know what Elsevier actually wants and if they care?

@northword
Copy link
Contributor Author

northword commented Dec 30, 2023

I think we should refer to the PDF of the latest issue of the journal, Elsevier's author's guide is basically a template, so many journals' author's guides are not consistent with what their PDFs provide, e.g., Applied Catalysis A, General, whose author's guide requires that the reference list not include the title of the paper, yet the PDF of the latest issue does include the Title.

image

image

Perhaps this PR requires the CSL team or community to reach a consensus on whether to use the author's guide or the latest PDF.

In addition, Elsevier's final manuscript PDFs are generated directly by its online proofing system, rather than editors manually maintaining a so-called author's guide, with a relatively high degree of reliability, and the DOI (https://doi.org/10.1016/j.heliyon.2018.e00205) for the examples given in the ACB's author's guide do not even exist.

@github-actions github-actions bot removed the waiting-for-response-from-contributor The ticket/pull request is awaiting input from the contributor/depositor label Dec 30, 2023
@northword
Copy link
Contributor Author

Could you make the same change to elsevier-with-titles-alphabetical.csl and elsevier-without-titles.csl?

elsevier-without-titles.csl is already correct and does not need to be changed; fix to elsevier-with-titles-alphabetical.csl have been pushed to this PR.

Copy link

😃 Your submission passed all our automated tests.

Below are some sample citations generated based on your proposed changes:

elsevier-with-titles-alphabetical.csl (modified style)
[1,2]
[3,4]

[1]CSL search by example, Citation Style Editor (2012).
[2]M. Fenner, M. Crosas, J.S. Grethe, D. Kennedy, H. Hermjakob, P. Rocca-Serra, G. Durand, R. Berjon, S. Karcher, M. Martone, T. Clark, A data citation roadmap for scholarly data repositories, Sci. Data 6 (2019) 28.
[3]B. Hancké, M. Rhodes, M. Thatcher, eds., Beyond varieties of capitalism: Conflict, contradiction, and complementarities in the European economy, Oxford University Press, Oxford and New York, 2007.
[4]I. Mares, Firms and the welfare state: When, why, and how does social policy matter to employers?, in: P.A. Hall, D. Soskice (Eds.), Varieties of Capitalism. The Institutional Foundations of Comparative Advantage, Oxford University Press, New York, 2001: pp. 184–213.
 [1,2]<br/>
 [3,4]<br/>
 <hr/>
-[1]CSL search by example, Citation Style Editor. (2012).<br/>
-[2]M. Fenner, M. Crosas, J.S. Grethe, D. Kennedy, H. Hermjakob, P. Rocca-Serra, G. Durand, R. Berjon, S. Karcher, M. Martone, T. Clark, A data citation roadmap for scholarly data repositories, Sci. Data. 6 (2019) 28.<br/>
+[1]CSL search by example, Citation Style Editor (2012).<br/>
+[2]M. Fenner, M. Crosas, J.S. Grethe, D. Kennedy, H. Hermjakob, P. Rocca-Serra, G. Durand, R. Berjon, S. Karcher, M. Martone, T. Clark, A data citation roadmap for scholarly data repositories, Sci. Data 6 (2019) 28.<br/>
 [3]B. Hancké, M. Rhodes, M. Thatcher, eds., Beyond varieties of capitalism: Conflict, contradiction, and complementarities in the European economy, Oxford University Press, Oxford and New York, 2007.<br/>
 [4]I. Mares, Firms and the welfare state: When, why, and how does social policy matter to employers?, in: P.A. Hall, D. Soskice (Eds.), Varieties of Capitalism. The Institutional Foundations of Comparative Advantage, Oxford University Press, New York, 2001: pp. 184–213.<br/>
elsevier-with-titles.csl (modified style)
[1,2]
[3,4]

[1]B. Hancké, M. Rhodes, M. Thatcher, eds., Beyond varieties of capitalism: Conflict, contradiction, and complementarities in the European economy, Oxford University Press, Oxford and New York, 2007.
[2]CSL search by example, Citation Style Editor (2012). http://editor.citationstyles.org/searchByExample/ (accessed December 15, 2012).
[3]I. Mares, Firms and the welfare state: When, why, and how does social policy matter to employers?, in: P.A. Hall, D. Soskice (Eds.), Varieties of Capitalism. The Institutional Foundations of Comparative Advantage, Oxford University Press, New York, 2001: pp. 184–213.
[4]M. Fenner, M. Crosas, J.S. Grethe, D. Kennedy, H. Hermjakob, P. Rocca-Serra, G. Durand, R. Berjon, S. Karcher, M. Martone, T. Clark, A data citation roadmap for scholarly data repositories, Sci. Data 6 (2019) 28. https://doi.org/10.1038/s41597-019-0031-8.
 [1,2]<br/>
 [3,4]<br/>
 <hr/>
 [1]B. Hancké, M. Rhodes, M. Thatcher, eds., Beyond varieties of capitalism: Conflict, contradiction, and complementarities in the European economy, Oxford University Press, Oxford and New York, 2007.<br/>
-[2]CSL search by example, Citation Style Editor. (2012). http://editor.citationstyles.org/searchByExample/ (accessed December 15, 2012).<br/>
+[2]CSL search by example, Citation Style Editor (2012). http://editor.citationstyles.org/searchByExample/ (accessed December 15, 2012).<br/>
 [3]I. Mares, Firms and the welfare state: When, why, and how does social policy matter to employers?, in: P.A. Hall, D. Soskice (Eds.), Varieties of Capitalism. The Institutional Foundations of Comparative Advantage, Oxford University Press, New York, 2001: pp. 184–213.<br/>
-[4]M. Fenner, M. Crosas, J.S. Grethe, D. Kennedy, H. Hermjakob, P. Rocca-Serra, G. Durand, R. Berjon, S. Karcher, M. Martone, T. Clark, A data citation roadmap for scholarly data repositories, Sci. Data. 6 (2019) 28. https://doi.org/10.1038/s41597-019-0031-8.<br/>
+[4]M. Fenner, M. Crosas, J.S. Grethe, D. Kennedy, H. Hermjakob, P. Rocca-Serra, G. Durand, R. Berjon, S. Karcher, M. Martone, T. Clark, A data citation roadmap for scholarly data repositories, Sci. Data 6 (2019) 28. https://doi.org/10.1038/s41597-019-0031-8.<br/>

@bwiernik
Copy link
Member

bwiernik commented Dec 31, 2023

@adam3smith From some casual checking of different issues of these and a handful of other journals, it seems pretty consistent that journals using Elsevier's house style don't using a period delimiter here in the PDFs

@github-actions github-actions bot added the waiting-for-response-from-contributor The ticket/pull request is awaiting input from the contributor/depositor label Dec 31, 2023
@adam3smith
Copy link
Member

Cool, that's good enough for me

@bwiernik bwiernik merged commit 40e5e02 into citation-style-language:master Jan 1, 2024
1 check passed
@bwiernik
Copy link
Member

bwiernik commented Jan 1, 2024

Thanks!

@northword northword deleted the remove-elsevier-journalAbbr-suffix branch January 1, 2024 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
waiting-for-response-from-contributor The ticket/pull request is awaiting input from the contributor/depositor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants