Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update harvard-imperial-college-london.csl #6829

Merged
merged 2 commits into from
Jan 22, 2024

Conversation

simomac
Copy link
Contributor

@simomac simomac commented Jan 2, 2024

Added disambiguate-add-year-suffix code to deal with multiple sources with the same author and no date. ref.: https://forums.zotero.org/discussion/105914/disambiguate-add-year-suffix-not-working-when-data-is-n-d-no-date-term/p1

Added disambiguate-add-year-suffix code to deal with multiple sources with the same author and no date. ref.: https://forums.zotero.org/discussion/105914/disambiguate-add-year-suffix-not-working-when-data-is-n-d-no-date-term/p1
Copy link

github-actions bot commented Jan 2, 2024

Awesome! You just created a pull request to the Citation Styles Language styles repository. One of our human volunteers will try to get in touch soon (usually within a week). In the meantime, I will run some automated checks. You should be notified of the results in a few minutes.

If you haven't done so yet, please make sure your style validates and follows all our other Style Requirements.

To update this pull request, visit the "Files changed" tab above, click on the ellipsis button in the top-right corner of your style, and then select "Edit file" to start editing:

If you have any questions, please leave a comment and we'll get back to you. While we usually respond in English, feel free to write in whatever language you're most comfortable.

Copy link

github-actions bot commented Jan 2, 2024

😃 Your submission passed all our automated tests.

Below are some sample citations generated based on your proposed changes:

harvard-imperial-college-london.csl (modified style; unchanged output for sample items)
(Anon, 2007; Anon, 2012)
(Mares, 2001; Fenner et al., 2019)

Anon (2012) CSL search by example. 2012. Citation Style Editor. http://editor.citationstyles.org/searchByExample/ [Accessed: 15 December 2012].
Fenner, M., Crosas, M., Grethe, J.S., Kennedy, D., Hermjakob, H., Rocca-Serra, P., Durand, G., Berjon, R., Karcher, S., Martone, M. & Clark, T. (2019) A data citation roadmap for scholarly data repositories. Scientific Data. 6 (1), 28. doi:10.1038/s41597-019-0031-8.
B. Hancké, M. Rhodes, & M. Thatcher (eds.) (2007) Beyond varieties of capitalism: Conflict, contradiction, and complementarities in the European economy. Oxford and New York, Oxford University Press.
Mares, I. (2001) Firms and the welfare state: When, why, and how does social policy matter to employers? In: P.A. Hall & D. Soskice (eds.). Varieties of capitalism. The institutional foundations of comparative advantage. New York, Oxford University Press. pp. 184–213.

@adam3smith
Copy link
Member

If you set the term explicitly on no date you also have to explicitly set it for years.

@github-actions github-actions bot added the waiting-for-response-from-contributor The ticket/pull request is awaiting input from the contributor/depositor label Jan 2, 2024
@simomac
Copy link
Contributor Author

simomac commented Jan 3, 2024

Thanks. There are 13 references to 'Year' in the code. Should I add '' after each instance?
eg: After
105
157
etc.?

@github-actions github-actions bot removed the waiting-for-response-from-contributor The ticket/pull request is awaiting input from the contributor/depositor label Jan 3, 2024
Copy link

😃 Your submission passed all our automated tests.

Below are some sample citations generated based on your proposed changes:

harvard-imperial-college-london.csl (modified style; unchanged output for sample items)
(Anon, 2007; Anon, 2012)
(Mares, 2001; Fenner et al., 2019)

Anon (2012) CSL search by example. 2012. Citation Style Editor. http://editor.citationstyles.org/searchByExample/ [Accessed: 15 December 2012].
Fenner, M., Crosas, M., Grethe, J.S., Kennedy, D., Hermjakob, H., Rocca-Serra, P., Durand, G., Berjon, R., Karcher, S., Martone, M. & Clark, T. (2019) A data citation roadmap for scholarly data repositories. Scientific Data. 6 (1), 28. doi:10.1038/s41597-019-0031-8.
B. Hancké, M. Rhodes, & M. Thatcher (eds.) (2007) Beyond varieties of capitalism: Conflict, contradiction, and complementarities in the European economy. Oxford and New York, Oxford University Press.
Mares, I. (2001) Firms and the welfare state: When, why, and how does social policy matter to employers? In: P.A. Hall & D. Soskice (eds.). Varieties of capitalism. The institutional foundations of comparative advantage. New York, Oxford University Press. pp. 184–213.

@adam3smith
Copy link
Member

You only need to add it to the relevant year macro, not every time the word "date" appears.

@adam3smith adam3smith merged commit 065a8d4 into citation-style-language:master Jan 22, 2024
1 check passed
@github-actions github-actions bot added the waiting-for-response-from-contributor The ticket/pull request is awaiting input from the contributor/depositor label Jan 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
waiting-for-response-from-contributor The ticket/pull request is awaiting input from the contributor/depositor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants