Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update american-journal-of-roentgenology.csl #6834

Closed

Conversation

drfrancisdeng
Copy link

Update to the AJR style including brackets for in-line citation and other modifications.

Copy link

github-actions bot commented Jan 4, 2024

Awesome! You just created a pull request to the Citation Styles Language styles repository. One of our human volunteers will try to get in touch soon (usually within a week). In the meantime, I will run some automated checks. You should be notified of the results in a few minutes.

If you haven't done so yet, please make sure your style validates and follows all our other Style Requirements.

To update this pull request, visit the "Files changed" tab above, click on the ellipsis button in the top-right corner of your style, and then select "Edit file" to start editing:

If you have any questions, please leave a comment and we'll get back to you. While we usually respond in English, feel free to write in whatever language you're most comfortable.

Copy link

github-actions bot commented Jan 4, 2024

😟 There are some issues with your submission.

4 tests failed

dependent/american-journal-of-roentgenology: must be a dependent style (independent styles must be placed in the root directory)

expected `#<CSL::Style xmlns="http://purl.org/net/xbiblio/csl" version="1.0" class="in-text" default-locale="en-GB" demote-non-dropping-particle="sort-only" children=[4]>.dependent?` to be truthy, got nil

dependent/american-journal-of-roentgenology: "independent-parent" link must point to an existing independent style

expected nil to match /^http:\/\/www.zotero.org\/styles\//

dependent/american-journal-of-roentgenology: may not have <macro/>, <citation/>, or <bibliography/> elements

expected `#<CSL::Style xmlns="http://purl.org/net/xbiblio/csl" version="1.0" class="in-text" default-locale="en-GB" demote-non-dropping-particle="sort-only" children=[4]>.has_macro?` to be falsey, got true

dependent/american-journal-of-roentgenology: must have the same citation-format as its independent-parent

undefined method `[]' for nil:NilClass

Please check the test report for details.

@drfrancisdeng
Copy link
Author

I have resubmitted a pull request to go to the independent directory rather than dependent.

@adam3smith
Copy link
Member

superseded by #6835

@adam3smith adam3smith closed this Jan 22, 2024
@github-actions github-actions bot added the waiting-for-response-from-contributor The ticket/pull request is awaiting input from the contributor/depositor label Jan 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
waiting-for-response-from-contributor The ticket/pull request is awaiting input from the contributor/depositor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants