Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crashes since recent update (zulu-helium-queen) GTA5_b3095.exe!sub_14039F848 (0x1929) #3069

Open
Senlar opened this issue Jan 15, 2025 · 28 comments
Assignees
Labels
bug crash triage Needs a preliminary assessment to determine the urgency and required action

Comments

@Senlar
Copy link

Senlar commented Jan 15, 2025

What happened?

GTA5_b3095.exe!sub_14039F848 (0x1929)
I noticed these crashes started on the beta client around January 5th and I was investigating scripts to see if I could find where it was coming from. Then, when the beta moved to release on January 13th it crippled my entire server.
image
image
image

Through the process of elimination I found a script that was previously working just fine, but now was resulting in a lot of these crashes. After stopping this script most of the crashes stopped, but they are still happening on occasion which leads me to believe it is possibly an issue with a native that is being used in other scripts as well. I am also seeing other server owners reporting issues with this crash on the CFX Discord so I know it is more than just an issue with one script on my server.

Here are some of the crash dumps from multiple players who provided them for this report.

CfxCrashDump_2025_01_13_15_52_48.zip
CfxCrashDump_2025_01_13_16_32_55.zip
CfxCrashDump_2025_01_13_17_19_50.zip
CfxCrashDump_2025_01_13_17_51_58.zip
CfxCrashDump_2025_01_13_18_31_06.zip
CfxCrashDump_2025_01_14_15_28_37.zip
CfxCrashDump_2025_01_14_03_55_58.zip

Expected result

Previously working scripts should not suddenly be causing crashes when they had not been updated or changed.

Reproduction steps

Its difficult to reproduce in an individual development environment... but on my server when I have players online if I start up the script it leads to an almost immediate crash for multiple players with the same crash message. But the crashes still happen to players when this script is not running so its not just this specific script.

Importancy

Crash

Area(s)

FiveM

Specific version(s)

[fivem:production] #12295

Server Info

windows:12255
set sv_enforceGameBuild 3095
sets sv_pureLevel 1

Additional information

No response

@Senlar Senlar added bug triage Needs a preliminary assessment to determine the urgency and required action labels Jan 15, 2025
@github-actions github-actions bot added the crash label Jan 15, 2025
@Senlar
Copy link
Author

Senlar commented Jan 15, 2025

I should mention that I did try to update my servers artifact and cleared the server cache.
image
This had no impact on the crashes.

@Envi-Scripts
Copy link

Been following this one with Senlar in his ticket in my discord and it seems that something in the latest client update has caused this problem for a small % of users of a particular one of my scripts. My best guess is being caused by the populationPedCreating event handler. Been a tricky one to diagnose as it is not happening for me on my test environment but I am happy to work with the team and share my code if needed.

@Msolomon256
Copy link

I’d be willing to bet that it’s multiple scripts that are causing this issue as well. Since reading this I’ve turned off all my envi scripts and still getting this error

@Gogsi
Copy link

Gogsi commented Jan 16, 2025

From a quick look, that function seems to be related to ped dialogue. I can see it gets a voice line to say and appends to it modifier like "_MALE", "_FEMALE", "_ANGRY", etc. Do any of you have any resources that would affect this dialogue?

@Envi-Scripts
Copy link

Envi-Scripts commented Jan 16, 2025

Yea I am using a lot of ped dialogue in my script, however the reports don't indicate that the client is interacting with my script at the time and seems more random. Could it be tied to something like scenario peds speech or something perhaps ?

@crimsoncoastrp
Copy link

Yeah brother we get it too with Envi trap phone…. This is very annoying, hopefully fivem fixes soon!

@Senlar
Copy link
Author

Senlar commented Jan 16, 2025

From a quick look, that function seems to be related to ped dialogue. I can see it gets a voice line to say and appends to it modifier like "_MALE", "_FEMALE", "_ANGRY", etc. Do any of you have any resources that would affect this dialogue?

@Gogsi If you don't mind me asking, how did you figure that out? Also, can you tell what native it is or does it not really point to a native?

@Envi-Scripts
Copy link

Just some more info I have gathered. Another user is getting it simply when car-jacking an NPC, which does relate to SPEECH I guess as they will be in that panicked state

@Msolomon256
Copy link

@DaniGP17
Copy link
Contributor

I don't know if it can help, but here is a signature that locates the crash place: 8B ? ? EB ? 41 ? ? 48 ? ? ? ? ? ? 85

@crimsoncoastrp
Copy link

Is fivem even somewhat aware of this so we can all fix our servers?

@Senlar
Copy link
Author

Senlar commented Jan 19, 2025

Is fivem even somewhat aware of this so we can all fix our servers?

Sadly it doesn't look like they've seen it yet. I would imagine they would take action on it here when they do by assigning someone or updating the tags.

@elvowe
Copy link

elvowe commented Jan 20, 2025

The same in my servers... It started on January 5th and got worse on the 12th, without having touched any of my scripts.

GTA5_b3258.exe!sub_1403A1D08 (0x1929)An error at GTA5_b3258.exe!sub_1403A1D08 (0x1929) caused FiveM to stop working. A crash report is being uploaded to the FiveM developers.
Legacy crash hash: pip-edward-vermont
GTA5_b3258.exe!sub_1403A1D08 (0x1929)

@DaniGP17
Copy link
Contributor

DaniGP17 commented Jan 20, 2025

The same in my servers... It started on January 5th and got worse on the 12th, without having touched any of my scripts.

GTA5_b3258.exe!sub_1403A1D08 (0x1929)An error at GTA5_b3258.exe!sub_1403A1D08 (0x1929) caused FiveM to stop working. A crash report is being uploaded to the FiveM developers.
Legacy crash hash: pip-edward-vermont
GTA5_b3258.exe!sub_1403A1D08 (0x1929)

But that crash is in 3258, not sure if it's related with this.(May be I'm wrong)

@elvowe
Copy link

elvowe commented Jan 20, 2025

Yep, its diferent build version, im using 3258 building. And the dates of the crashes started right on those days (where I didn't make any script updates)

Image

@Gogsi
Copy link

Gogsi commented Jan 20, 2025

The same in my servers... It started on January 5th and got worse on the 12th, without having touched any of my scripts.

GTA5_b3258.exe!sub_1403A1D08 (0x1929)An error at GTA5_b3258.exe!sub_1403A1D08 (0x1929) caused FiveM to stop working. A crash report is being uploaded to the FiveM developers.
Legacy crash hash: pip-edward-vermont
GTA5_b3258.exe!sub_1403A1D08 (0x1929)

I can confirm this is the same crash, just a different offset because it's a different build. The fact that it started on the same day and has the same offset inside the function (0x1929) is also a good hint that it's related.

Had a bit more time to look into it, and it's crashing when attempting to get the current script thread ID. Weirdly enough it first calls "_GetCurrentThread" (made up name) to check if it's not null and then calls it a second time to get its ID. For some reason though, the second time the script thread is null despite passing the check in the if. Maybe an oddity given how FiveM handles scripts or maybe something in adhesive?

Image

Relevant code snippet, the crash is when adding 2 (8 bytes) to the scrThread* to get the ID

@Gogsi
Copy link

Gogsi commented Jan 20, 2025

Commits 636b97b and 4a02b90 both made it to production on that day (January 13) and the first one changes stuff in GtaThread, while the second one changes stuff in both GtaThread and scrThread. If I had to guess, the issue probably lies there but I don't know what it is right now.

@prikolium-cfx prikolium-cfx self-assigned this Jan 20, 2025
@tens0rfl0w
Copy link
Contributor

Probably related issue: #3079 (Crashing on reset calls to scrThread)

@Senlar
Copy link
Author

Senlar commented Jan 24, 2025

Hopefully there is enough information here to help track down the cause of this issue. If we can provide any other information please let us know.

@chopcity1oh
Copy link

chopcity1oh commented Jan 25, 2025

getting it again even after updating trap phone, it worked for a week now it happened again... THIS IS THE TRAP PHONE GENERALLY WHEN WE GO UP TO GANG MEMBER CARS.

@harr9i
Copy link

harr9i commented Jan 27, 2025

Hopefully there is enough information here to help track down the cause of this issue. If we can provide any other information please let us know.

I was being carried in a car when the crash happened once (I thought it was a server problem), I joined back and just started walking on the shoulder of the highway bc I was in full rp mode lol and crashed maybe two minutes later again, its very frustrating ngl.

@chopcity1oh
Copy link

I linked this to here, comment on this maybe cfx will see it.

https://forum.cfx.re/t/legacy-crash-hash-pip-edward-vermont/5301934

@DaniGP17
Copy link
Contributor

I linked this to here, comment on this maybe cfx will see it.

There is already a cfx person assigned to this issue

@chopcity1oh
Copy link

@chopcity1oh
Copy link

I linked this to here, comment on this maybe cfx will see it.

There is already a cfx person assigned to this issue

GOOD TO KNOW BROTHER!

@tomson701
Copy link

Any info?

@chopcity1oh
Copy link

We are crashing MUCH less with the new envi trap phone update but still pretty often. PLEASE FIVEM FIX THIS LOL

@chopcity1oh
Copy link

Any info?

nope!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug crash triage Needs a preliminary assessment to determine the urgency and required action
Projects
None yet
Development

No branches or pull requests