Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dirty content restored incorrectly when navigating back from pull request link #64

Closed
mlewand opened this issue Feb 10, 2020 · 2 comments · Fixed by #69
Closed

Dirty content restored incorrectly when navigating back from pull request link #64

mlewand opened this issue Feb 10, 2020 · 2 comments · Fixed by #69
Assignees
Labels
bug Something isn't working

Comments

@mlewand
Copy link
Contributor

mlewand commented Feb 10, 2020

  1. Open a PR with some review comments in it.
  2. Start typing a response in one of the review comments.
  3. Without submitting the comment click on the "view changes" link.
  4. Navigate back in the browser history.

Expected

Former content being preserved.

Actual

There are two editors, and toolbar is not rendered correctly.


There's a (lenghty) GIF showing how it looks like:

@fredck fredck added the bug Something isn't working label Feb 12, 2020
@fredck
Copy link
Contributor

fredck commented Feb 12, 2020

There are two editors, and toolbar is not rendered correctly.

This is a dup of #55, which has been fixed.

There's a (lenghty) GIF showing how it looks like

The gif is not working for me... it shows as an static image... but I assume this is something like the one we see in #55.

Former content being preserved.

This is the valid part of this issue, I assume. Needs check.

@fredck
Copy link
Contributor

fredck commented Feb 13, 2020

Good part of this issue has been now fixed with #68.

The result is not totally right still in Pull Request pages though. That's because it uses pjax when switching between its tabs. Although #68 solves most of the pjax integration, the data update still suffers because of defunkt/jquery-pjax#721. Basically, the editor is not able to update the textarea before pjax takes a snapshot of the current dom.

I'll keep on investigating this issue and hopefully something will pop out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants