Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(nextjs): Handle __nextGetStaticStore returning undefined #3939

Merged
merged 1 commit into from
Aug 13, 2024
Merged

fix(nextjs): Handle __nextGetStaticStore returning undefined #3939

merged 1 commit into from
Aug 13, 2024

Conversation

panteliselef
Copy link
Member

@panteliselef panteliselef commented Aug 13, 2024 •
edited
Loading

Description

Bug fix: Handle nextGetStore.getStore() returning undefined. Previously a TypeError would occur, when pagePath was accessed.

Fixes: #3772

Checklist

  • npm test runs as expected.
  • npm run build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

@panteliselef panteliselef self-assigned this Aug 13, 2024
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Aug 13, 2024

🦋 Changeset detected

Latest commit: 5a90f37

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@clerk/nextjs Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@panteliselef
Copy link
Member Author

!snapshot

@clerk-cookie
Copy link
Collaborator

Hey @panteliselef - the snapshot version command generated the following package versions:

Package Version
@clerk/astro 1.0.12-snapshot.v5a90f37
@clerk/backend 1.6.3-snapshot.v5a90f37
@clerk/chrome-extension 1.2.1-snapshot.v5a90f37
@clerk/clerk-js 5.14.1-snapshot.v5a90f37
@clerk/elements 0.13.0-snapshot.v5a90f37
@clerk/clerk-expo 2.1.1-snapshot.v5a90f37
@clerk/express 0.0.28-snapshot.v5a90f37
@clerk/fastify 1.0.30-snapshot.v5a90f37
@clerk/localizations 2.5.8-snapshot.v5a90f37
@clerk/nextjs 5.3.1-snapshot.v5a90f37
@clerk/clerk-react 5.4.1-snapshot.v5a90f37
@clerk/remix 4.2.14-snapshot.v5a90f37
@clerk/clerk-sdk-node 5.0.27-snapshot.v5a90f37
@clerk/shared 2.5.1-snapshot.v5a90f37
@clerk/tanstack-start 0.2.1-snapshot.v5a90f37
@clerk/testing 1.2.10-snapshot.v5a90f37
@clerk/themes 2.1.20-snapshot.v5a90f37
@clerk/types 4.13.1-snapshot.v5a90f37
@clerk/ui 0.1.8-snapshot.v5a90f37

Tip: Use the snippet copy button below to quickly install the required packages.
@clerk/astro

npm i @clerk/[email protected] --save-exact

@clerk/backend

npm i @clerk/[email protected] --save-exact

@clerk/chrome-extension

npm i @clerk/[email protected] --save-exact

@clerk/clerk-js

npm i @clerk/[email protected] --save-exact

@clerk/elements

npm i @clerk/[email protected] --save-exact

@clerk/clerk-expo

npm i @clerk/[email protected] --save-exact

@clerk/express

npm i @clerk/[email protected] --save-exact

@clerk/fastify

npm i @clerk/[email protected] --save-exact

@clerk/localizations

npm i @clerk/[email protected] --save-exact

@clerk/nextjs

npm i @clerk/[email protected] --save-exact

@clerk/clerk-react

npm i @clerk/[email protected] --save-exact

@clerk/remix

npm i @clerk/[email protected] --save-exact

@clerk/clerk-sdk-node

npm i @clerk/[email protected] --save-exact

@clerk/shared

npm i @clerk/[email protected] --save-exact

@clerk/tanstack-start

npm i @clerk/[email protected] --save-exact

@clerk/testing

npm i @clerk/[email protected] --save-exact

@clerk/themes

npm i @clerk/[email protected] --save-exact

@clerk/types

npm i @clerk/[email protected] --save-exact

@clerk/ui

npm i @clerk/[email protected] --save-exact

BRKalow
BRKalow approved these changes Aug 13, 2024
View reviewed changes
Copy link
Member

@BRKalow BRKalow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

@panteliselef panteliselef merged commit c443544 into main Aug 13, 2024
21 checks passed
@panteliselef panteliselef deleted the elef/user-581-nextjs-get-store-undefined branch August 13, 2024 19:30
@clerk-cookie clerk-cookie mentioned this pull request Aug 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@octoper octoper octoper approved these changes

@BRKalow BRKalow BRKalow approved these changes

@nikosdouvlis nikosdouvlis Awaiting requested review from nikosdouvlis

@dimkl dimkl Awaiting requested review from dimkl

Assignees

@panteliselef panteliselef

Labels
nextjs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Routing failed. TypeError: Cannot read properties of undefined (reading 'pagePath'
4 participants
@panteliselef @clerk-cookie @BRKalow @octoper