Update to version 0.2.0 #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anthonyoconnorclio
approved these changes
Jun 11, 2024
Drew-Goddyn
reviewed
Jun 11, 2024
| @@ -1,3 +1,3 @@ | |||
| module InheritanceIntegerType | |||
| VERSION = "0.1.3" | |||
| VERSION = "0.2.0" | |||
There was a problem hiding this comment.
why the bump to 0.2.0 instead of say 0.1.4?
There was a problem hiding this comment.
I thought it was because it is a more major change since this is dropping ruby 2.7 support.
Maybe breaking change is better wording than more major ;)
There was a problem hiding this comment.
Yup what @anthonyoconnorclio said. Ruby 3 vs 2.7 (we can argue semver if you like) I wanted it to be clear that if you want to change ruby versions its a clear minor version bump rather and a incremental patch level bump.
Easier to clarify in the docs too, IMO.
Drew-Goddyn
approved these changes
Jun 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the title states, version bump to separate the Ruby 3 supported version. In addition this drops Ruby v2.7 and ActiveRecord < 6.1 support in CI.