Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider removing unused internal legacy code #147

Open
lread opened this issue Apr 3, 2021 · 0 comments
Open

Consider removing unused internal legacy code #147

lread opened this issue Apr 3, 2021 · 0 comments

Comments

@lread
Copy link
Collaborator

lread commented Apr 3, 2021

Problem/Opportunity
While hunting for what macros rewrite-clj exposes, I noticed a couple of unexposed/unused/undocumented/untested ones under the internal rewrite-clj.node.whitespace namespace:

  • with-newline-fn
  • with-count-fn

They have an associated a couple of associated dynamic vars:

  • *newline-fn*
  • *count-fn*

Proposed Solution
Delete them.

Alternative Solutions

  • Expose them and support them.
  • Leave them in and mark them as deprecated.

Additional context
I'll try to determine if these are relevant today, and if anybody is using them.
If not, out they go.

Action
I'll follow up.

@lread lread added this to rewrite-clj Jul 3, 2024
@lread lread moved this to Medium Priority in rewrite-clj Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Medium Priority
Development

No branches or pull requests

1 participant