Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wow vanilla map pins are broken #20

Open
BannZay opened this issue Dec 14, 2024 · 0 comments · May be fixed by #21
Open

Wow vanilla map pins are broken #20

BannZay opened this issue Dec 14, 2024 · 0 comments · May be fixed by #21

Comments

@BannZay
Copy link

BannZay commented Dec 14, 2024

HereBeDragons pins throws an exception when you tries to add a pin for class trainer.
Tested on wow vanilla (11505) with only following addons enabled: FieldGuide, BugSack, BugGrabber.

Using the addon along with other dependant on HereBeDragons addons like RXPGuides, makes blizzard map completely broken.

I really like the addon and fixed my version by upgrading HereBeDragons (from v16) to the latest(v29) and tested. Both v29 and v27 worked perfectly).

Buggrabber Exception 348x ...aceBlizzard_MapCanvas/Blizzard_MapCanvas.lua:165: attempt to call method 'OnLoad' (a nil value) [string "@Blizzard_MapCanvas/Blizzard_MapCanvas.lua"]:165: in function `AcquirePin' [string "@RareScanner/ExternalLibs/HereBeDragons/HereBeDragons-Pins-2.0.lua"]:451: in function `HandlePin' [string "@RareScanner/ExternalLibs/HereBeDragons/HereBeDragons-Pins-2.0.lua"]:391: in function `RefreshAllData' [string "@Blizzard_MapCanvas/MapCanvas_DataProviderBase.lua"]:76: in function `OnMapChanged' [string "@Blizzard_MapCanvas/Blizzard_MapCanvas.lua"]:534: in function `OnMapChanged' [string "@Blizzard_WorldMap/Vanilla/Blizzard_WorldMap.lua"]:256: in function <...dOns/Blizzard_WorldMap/Vanilla/Blizzard_WorldMap.lua:255> [string "=[C]"]: ? [string "=[C]"]: ? [string "=[C]"]: ? [string "=[C]"]: in function `OnMapChanged' [string "@Blizzard_MapCanvas/Blizzard_MapCanvas.lua"]:39: in function `SetMapID' [string "@Blizzard_WorldMap/Vanilla/Blizzard_WorldMap.lua"]:278: in function <...dOns/Blizzard_WorldMap/Vanilla/Blizzard_WorldMap.lua:276> [string "=[C]"]: ? [string "=[C]"]: in function `Show' [string "@Blizzard_UIParentPanelManager/Classic/UIParentPanelManager_Shared.lua"]:603: in function `SetUIPanel' [string "@Blizzard_UIParentPanelManager/Classic/UIParentPanelManager_Shared.lua"]:409: in function `ShowUIPanel' [string "@Blizzard_UIParentPanelManager/Classic/UIParentPanelManager_Shared.lua"]:316: in function <...PanelManager/Classic/UIParentPanelManager_Shared.lua:312> [string "=[C]"]: in function `SetAttribute' [string "@Blizzard_UIParentPanelManager/Classic/UIParentPanelManager_Shared.lua"]:1091: in function `ShowUIPanel' [string "@Blizzard_WorldMap/Vanilla/Blizzard_WorldMap.lua"]:17: in function `HandleUserActionToggleSelf' [string "@Blizzard_WorldMap/Vanilla/Blizzard_WorldMap.lua"]:324: in function `ToggleWorldMap' [string "TOGGLEWORLDMAP"]:1: in function <[string "TOGGLEWORLDMAP"]:1>

Locals:
self = WorldMapFrame {
expandedMapInsetsByMapID =

{
}
pinNudgingDirty = true
ZoneDropdown = WorldMapZoneDropdown {
}
minimizedHeight = 438
lockReasons =
{
}
MiniBorderFrame = Frame {
}
callbackTables =
{
}
pinPools =
{
}
dataProviderEventsCount =
{
}
mouseClickHandlers =
{
}
pinTemplateTypes =
{
}
maximizedWidth = 1024
maximizedHeight = 768
activeAreaTriggers =
{
}
MaximizeMinimizeFrame = Frame {
}
MinimapDropdown = WorldMapZoneMinimapDropdown {
}
mapArtID = 1202
areDetailLayersDirty = false
minimizedWidth = 610
debugAreaTriggers = false
pinFrameLevelsManager =
{
}
pinsToNudge =
{
}
dataProviders =
{
}
detailLayerPool =
{
}
isUndefinedEventAllowed = true
MaxMinButtonFrame = Frame {
}
BorderFrame = Frame {
}
ScrollContainer = ScrollFrame {
}
BlackoutFrame = Frame {
}
mapID = 1413
ContinentDropdown = WorldMapContinentDropdown {
}
}
pinTemplate = "HereBeDragonsPinsTemplate"
pin = Frame {
owningMap = WorldMapFrame {
}
pinTemplate = "HereBeDragonsPinsTemplate"
}
newPin = true
(*temporary) = nil
(*temporary) = Frame {
owningMap = WorldMapFrame {
}
pinTemplate = "HereBeDragonsPinsTemplate"
}
(*temporary) = "attempt to call method 'OnLoad' (a nil value)"
@BannZay BannZay linked a pull request Dec 14, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Upgrade HereBeDragons to v29 (v15 pins) BannZay/FieldGuide
1 participant
@BannZay