Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RPKI endpoint returns invalid JSON on some ASNs #683

Open
danog opened this issue May 9, 2023 · 9 comments
Open

RPKI endpoint returns invalid JSON on some ASNs #683

danog opened this issue May 9, 2023 · 9 comments

Comments

@danog
Copy link

danog commented May 9, 2023

For example, when running curl -6 https://valid.rpki.cloudflare.com/bc66fd0d2 from my AS198747, the following invalid JSON payload is returned:

{"status":"valid", "asn":undefined, "name": "", "blackholed":false}

Not quite sure as to why the AS name isn't picked up from the RIPE database entry, but either way that field should contain at least null , not undefined, as that's invalid JSON that causes a generic error when running the test.

@digizeph
Copy link
Collaborator

Thanks for submitting the report! It seems like the AS name is updated on RIPE DB as well as showing up on Cloudflare Radar. Could you help verify that the query returns correct ASN and names now?

@danog
Copy link
Author

danog commented Jun 15, 2023

Hi, yes it got fixed a while ago, but still, I feel like the backend should never return an invalid JSON payload in any condition, that feels deeply wrong :)

@danog
Copy link
Author

danog commented Jun 16, 2023

Oh and also I noticed a really strange thing, looks like the security & attack dashboard is showing bogus data, not only it is showing a seemingly random percentage of network layer attacks coming from what is essentially my home network consisting of a few android devices and a raspberry pi hosting jellyfin, it is also showing data up until January 2023, even if the AS was created on 2023-04-25.

It seems like it's just showing randomly generated numbers, that doesn't seem right :)

@G4brym
Copy link
Member

G4brym commented Jun 16, 2023

Hey @danog
There was a bug in the Radar API, that was ignoring the ASN filter in that specific DOS endpoint, thats why you were seeing big numbers in your ASN.
The data that was being displayed there was the worldwide DOS data, here is a quick side-by-side comparison of your ASN page vs worldwide
image

The issue is fixed now, and thanks for reporting it

@danog
Copy link
Author

danog commented Jun 16, 2023

Thank you, awesome!
Has anyone fixed the other issue with the invalid JSON response returned by the rpki endpoint yet, can I close this issue?

@FrostTheFox
Copy link

FrostTheFox commented Jan 30, 2024

I'm also running into this issue, from behind AS30690 I'm receiving the same invalid JSON response which causes an error to be displayed instead of test results:
{"status":"valid", "asn":undefined, "name": "", "blackholed":false}

The ASN does show up correctly on Radar and of course is reflected in ARIN records.

@G4brym
Copy link
Member

G4brym commented Feb 2, 2024

Hey @FrostTheFox and @danog i've pushed a fix to https://valid.rpki.cloudflare.com, can you check if the endpoint is returning valid json now?

@FrostTheFox
Copy link

FrostTheFox commented Feb 3, 2024

Hey @FrostTheFox and @danog i've pushed a fix to https://valid.rpki.cloudflare.com, can you check if the endpoint is returning valid json now?

It's valid on my end now! :)

@danog
Copy link
Author

danog commented Feb 4, 2024

My issue got already fixed several months ago, probably due to the propagation of some entry in some database, so I can't really check if the issue is still there without creating a new AS :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants