Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Chore] Improve logging #3768

Open
danail-branekov opened this issue Jan 30, 2025 · 0 comments
Open

[Chore] Improve logging #3768

danail-branekov opened this issue Jan 30, 2025 · 0 comments

Comments

@danail-branekov
Copy link
Member

danail-branekov commented Jan 30, 2025

Background

Korifi is logging a lot. The overwhelming amount of logs we produce makes troubleshooting hard. Furthermore, we often get log severity wrong. For example, if a controller sees that the object it reconcile is missing a dependency, it logs an error. That dependency quite probably would appear eventually, so those errors simply introduce noise.

Action to take

  • Come up with a guideline how to log temporary errors (e.g. agree on a log severity)
  • Come up with a guideline what is considered an error that operators should be bothered with
  • Come up with a guideline whether to log, or put a "not-ready" reason in the object status. Or maybe fire a k8s event?
  • Check all the places (both api and controllers land) we log stuff and apply those guidelines
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: 🧊 Icebox
Development

No branches or pull requests

1 participant