Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HttpListener] This feature has nothing to do with GauloisPipe #59

Open
cmarchand opened this issue Jul 18, 2021 · 1 comment
Open

[HttpListener] This feature has nothing to do with GauloisPipe #59

cmarchand opened this issue Jul 18, 2021 · 1 comment

Comments

@cmarchand
Copy link
Owner

Starting GauloisPipe as a HttpListener was a request for a project at Francis Lefebvre / Lefebvre-Sarrut.

This feature is an integration feature, and has nothing to do with pipeline processing. If a client need to start a GauloisPipe as a service, then GauloisPipe has to be startable as a service, needs to provide an API to add new files in queue, needs to provide an API to stop, but it must not provide an Http Server.

This feature requires a dependency on jetty:jetty-server, and this library has quite often vulnerabilities. Removing the http service will secure gaulois-pipe, and let each integrator integrate gaulois-pipe as he likes, removing the constraint to use jetty.

As this change introduce a breaking-change, this should be done in a major release.

@cmarchand
Copy link
Owner Author

@mricaud : your opinion, as your company is the most impacted with this...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant