No .vv file downloaded

[aaaaadrien]

Explain what happens

1. Open cockpit
2. Go to Virtual Machines tab
3. Start a VM
4. Clic on Launch remote viewer

The file has no extension.
On Google Chrome : "download"
On Firefox : "FHfpQ1UH"
On Vivaldi : "file"

With No extension, open the file directly in the browser (to not download it) didn't work because the association is with extension.

Version of Cockpit

cockpit-machines 325

Where is the problem in Cockpit?

Unknown or not applicable

Server operating system

Fedora

Server operating system version

41

What browsers are you using?

Firefox, Chrome, Other

System log

No response

[garrett]

This is a regression; .vv used to be added at the end of the file at some point in time. It was a while ago when this worked though.

The fix is to use a URL like this:

<a href="DATA-URI" download="filename.vv" class="pf-v5-c-button">Button label</a>

We could also do this via JavaScript with something like this vanilla JavaScript instead (which basically accepts an object dynamically wraps up the above HTML and clicks it):

const downloadVirtViewerFile = (content, filename = 'virt-viewer-launcher.vv') => {
  // Create a data URL with the content and filename
  const dataURI = URL.createObjectURL(new File(content, filename, { type: 'text/plain' }));

  // Create an anchor (link), assign the content and filename, then click it
  Object.assign(document.createElement('a'), { href: dataURI, download: filename }).click();

  // Release the memory
  URL.revokeObjectURL(dataURI);
};

(Perhaps there's some React stuff that can do some of these things automatically; I don't know.)

[garrett]

Oh, BTW: the mimetype might need to be application/x-virt-viewer