Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

static properties misuse of colon instead of = ? #5

Open
niksosf opened this issue Mar 6, 2017 · 5 comments
Open

static properties misuse of colon instead of = ? #5

niksosf opened this issue Mar 6, 2017 · 5 comments

Comments

@niksosf
Copy link

niksosf commented Mar 6, 2017

Hi there, I think the colon in
export default class FloatingLabel extends React.Component { static propTypes: {

is throwing error in babel. Is it also the case on your end? I am using web pack 2 with .babelrc like this
{ "presets": [ ["es2015", { "modules": false}], "react", "stage-0" ], "plugins": ["react-hot-loader/babel"] }

shouldn't it be static propTypes = {...}

@kusakusakusa
Copy link

I could get it to work by using babel-preset-stage-2.

@niksosf
Copy link
Author

niksosf commented Aug 11, 2017

Well that's odd because stage 0 include stage 2

@kusakusakusa
Copy link

oh yes you're right. I've always thought that it is the other way round hahah

This is my .babelrc. Im using webpack 3 though.

{
  "presets": ["react", "es2015", "stage-2"],
  "env": {
    "development": {
      "presets": ["react-hmre"]
    }
  }
}

@gokulkrishh
Copy link
Member

@VIC-L Thanks for helping out @niksosf 👍

@joeyparis
Copy link

joeyparis commented Mar 2, 2018

I still get the same error when using @VIC-L's exact .babelrc configuration with Webpack 3.5.5.

I'm working on top of a react-boilerplate framework if that changes anything

It looks like react-boilerplate doesn't apply babel to files in node_modules. I was able to get it working by applying babel to the node_modules directory as well, but that drastically increased build time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants