Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate expanded jsonld document version from form to use for validation #29

Open
hjonin opened this issue Mar 13, 2024 · 3 comments
Open

Comments

@hjonin
Copy link
Contributor

hjonin commented Mar 13, 2024

          Ah, indeed. Eventually we should make the main code generate the expanded value directly, but let's keep this for a future PR.

Originally posted by @progval in #27 (comment)

Now that we are using jsonld.jd to generate the codemeta document, we could also generated the jsonld expanded version of the document directly from the form fields and then work with the expanded document.

@progval
Copy link
Member

progval commented Mar 13, 2024

(for future readers:) we only mean this for the internal representation; the output should remain the compacted form

@hjonin
Copy link
Contributor Author

hjonin commented Mar 20, 2024

On it

hjonin added a commit to hjonin/codemeta-generator that referenced this issue Mar 27, 2024
* Expand jsonld from custom context
* Resolves codemeta#29
@hjonin hjonin changed the title Generate expanded jsonld document version from form Generate expanded jsonld document version from form to use for validation Apr 4, 2024
@hjonin
Copy link
Contributor Author

hjonin commented Apr 4, 2024

work with the expanded document

means update https://github.com/hjonin/codemeta-generator/blob/3c76b4b876df2de62e6f88eaeedc1bdfa0437a03/js/validation/index.js#L16

function validateDocument(doc) {

to take the expanded version for input.

(cf. #34 (comment))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants