Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Users] Implement undo user delete feature #135

Open
4 tasks
thenamankumar opened this issue Jun 10, 2020 · 9 comments
Open
4 tasks

[Users] Implement undo user delete feature #135

thenamankumar opened this issue Jun 10, 2020 · 9 comments

Comments

@thenamankumar
Copy link
Contributor

Once #134 is resolved, we need a way to undo the delete by the admins.

  • add a userEnable mutation to undo the delete.
  • allowed only for admins.
  • add an argument to the users query type named 'includeDisabled' based on which you include the disabled entities in the results too. By default it can be false. Even if it is true, the disabled entities shall only be included if the user is admin.
  • in the users query type, the default order should be based on the deleted_at, and should also be used as a fallback even if another column is provided via args to sort based on.
@jugshaurya
Copy link
Contributor

@hereisnaman, on it!

@Ayush-Mahajan
Copy link

Is this issue still open?

@thenamankumar
Copy link
Contributor Author

Is this issue still open?

Yes

@jugshaurya
Copy link
Contributor

Is this issue still open?

Yes working on it. Just waiting for #134 to be merged.

@Ayush-Mahajan
Copy link

So can I start working on it or should I wait for another issue to open up. I am new to BOSS so i dont have much experience with how exactly does the scoring and all works @hereisnaman

@jugshaurya
Copy link
Contributor

jugshaurya commented Jun 16, 2020

So can I start working on it or should I wait for another issue to open up. I am new to BOSS so i dont have much experience with how exactly does the scoring and all works @hereisnaman

@Ayush-Mahajan, welcome to open source. There are other issues as well besides this. But you are more than welcome to work on this issue as well. But since this issue depends upon #134 issue of which i have submitted a PR, just waiting for its testing. You can start by testing my PR as well. #138

@Ayush-Mahajan
Copy link

@jugshaurya thanks. I tried looking for other issues but i think all of them are taken

@jugshaurya
Copy link
Contributor

@jugshaurya thanks. I tried looking for other issues but i think all of them are taken

As of now nothing is taken you can work on any issue and submit a PR. If they like it it will get merged. By the out of 6 issues in this repo 4 are not taken by anyone or no one has worked in last 5 days. So you can work there.also try other repos like codingblocks boss repo. Good luck

@Ayush-Mahajan
Copy link

ohh thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants