Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

At login's screen password field value is been saved on LocalStorage (text plain) #119

Open
devdesignerstudio opened this issue Jul 23, 2023 · 1 comment

Comments

@devdesignerstudio
Copy link

devdesignerstudio commented Jul 23, 2023

i've sent you an e-mail about coinOS security breach
subject: field password at Login screen
since you are saving it on Local Storage
besides you are saving non encrypted password on it
and you do not clean it after user logging in
so imagine a possible use case: a staff who receives payment for his employer
a malicious unsatisfied staff
could take a look at "password" storage key in Local Storage without problems and steal it occasionally
today your app is only cleanning it up after user logging out
i believe it is a security breach
but its up to you
you're welcome
best regards

@devdesignerstudio
Copy link
Author

devdesignerstudio commented Jul 24, 2023

in my poor opinion
i believe
Since you are using JWT after user loggin in
requesting field "token" on Session Cookie
to authenticate user through your app
you should have cleaned password value input on local storage
or should have never set it there

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant