Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update build instructions for windows #142

Open
collinsmith opened this issue Jul 24, 2021 · 5 comments
Open

Update build instructions for windows #142

collinsmith opened this issue Jul 24, 2021 · 5 comments

Comments

@collinsmith
Copy link
Owner

collinsmith commented Jul 24, 2021

Need to update build instructions to try and remove any hoops people need to jump through, namely implement usage of scoop. Could also add instruction on setting up dev environment with intellij.

scoop install git
scoop install zulu15
git clone http://github.com/collinsmith/riiablo
cd riiablo
.\gradlew desktop:run --args="--d2 <path_to_d2>"
scoop install idea
.\gradlew idea (generates idea project files correctly)
idea64 (starts idea)
... add zulu15 install dir to intellij jdks ...
open project (should ask to load project gradle scripts and to trust project gradle build scripts)
@micheljung
Copy link

Fixing compile errors would be a first step :) I cloned the project, imported in into intellij but imports and classes are missing

@collinsmith
Copy link
Owner Author

collinsmith commented Oct 7, 2021

Fixing compile errors would be a first step :) I cloned the project, imported in into intellij but imports and classes are missing

@micheljung Which error messages are you seeing? You should be building with gradlew to generate some of the sources. E.g., code which relies on the generated network packet classes or generated constants for the compiled version/date

@micheljung
Copy link

micheljung commented Oct 8, 2021

I didn't put too much effort into it, e. g. I didn't install the Android SDK. I was only interested in the excel part and in there, there is a reference to PrimaryKeyAnnotatedElement for which there is no import, nor does such a class exist anywhere:

https://github.com/collinsmith/riiablo/search?q=PrimaryKeyAnnotatedElement

@collinsmith
Copy link
Owner Author

I didn't put too much effort into it, e. g. I didn't install the Android SDK. I was only interested in the excel part and in there, there is a reference to PrimaryKeyAnnotatedElement for which there is no import, nor does such a class exist anywhere:

https://github.com/collinsmith/riiablo/search?q=PrimaryKeyAnnotatedElement

@micheljung That code path was disabled because it's in development (excel.annotation-processor), so I must have missed that file when committing. I've added it to repo if you want to do another pull. That specific file is literally just a container for primary key fields for metadata use in the annotation processor. See 7e7b340

@collinsmith
Copy link
Owner Author

Below is for opening the project for IDEA -- not building specifically.

8287515 added support for generating sources when generating project for idea
.\gradlew idea will generate an IDEA .ipr project file which can be loaded by IDEA (which then asks to load gradle stuff, which then asks to be trusted). Should load riiablo.ipr when opening project so it works correctly. IDEA will throw a warning like below about duplicate content roots which can be ignored -- caused by having assets in root folder and shared (seems can be avoided by having assets in android project, but I don't like that structure and will avoid as long as possible).

1:08 PM	Duplicate content roots detected: Path [C:/Users/csmith/projects/riiablo/assets] of module [riiablo.android] was removed from modules [riiablo.core.main, riiablo.desktop.main, riiablo.server.d2gs.main, riiablo.server.netty.main, riiablo.tools.ds1-viewer.main]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants