-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
glomap mapper results are significantly worse than clomap #128
Comments
But in fact, it can be imagined that the global bundle adjustment would not be as robust as the incremental one |
Hi @Jacky56, thanks for the questions. Regarding the result, would you mind sharing the extracted |
Hello @lpanaf, colmap feature_extractor --database_path '/tmp/test/database.db' --image_path '/tmp/test/images' --SiftExtraction.use_gpu 0 colmap feature_extractor --database_path '/tmp/test/database.db' --image_path '/tmp/test/images' --SiftExtraction.use_gpu 0 --ImageReader.single_camera=1 |
Hi @Jacky56, thanks for the data. I tried with If you feed these reconstructions into your gsplat pipeline, you should see similar result :) |
Hi @Jacky56, can you maybe be more specific on this comment? I am not very familiar with gsplat terms so I don't quite understand what this means. I checked gsplat from both GLOMAP and COLMAP, and they look similar to me. |
Hi @lpanaf, I am having similar difficulties with the quality of output from glomap compared to colmap. I have tried with varying size datasets with different levels of success. For sake of iteration I chose a small self collected dataset that I just could not get glomap to reconstruct where as colmap did just fine. Here is the dataset https://huggingface.co/datasets/pablovela5620/example-colmap-glomap/tree/main and I used colmap/glomap with superpoint and lightglue using the following mapper command
I will also add that I made matching sequential instead of exhaustive or vocab tree since it was taken via a video sequence so I also used a shared camera paramter |
@pablovela5620 Hi, thanks for sharing the data. I noticed only the matches and descriptors are available but not the |
Happy to, here you go I ran and reuploaded (basically the same results, but this time on the 100 it got split into 2 different models). The database.db should be there for both |
Hi @pablovela5620, thanks for the database. I have tried to reconstruct with it, and it turns out that the reconstruction of GLOMAP is very similar to COLMAP The reason that it looks very different is that COLMAP rescales the reconstruction to be approximate at range (0, 5), while GLOMAP does not perform this step, and in the case of this dataset, it is very small so that you cannot properly view it. We would work on a pull request to include this reconstruction normalization step for better visualization. |
This is awesome thank you! I appreciate you taking the time to help me debug this. It would be very helpful to have the visualizations between glomap/colmap to have the same post processing. I'm currently working on doing a bunch more testing for glomap/colmap as the speed of reconstruction from glomap is just so much faster |
@pablovela5620 We have incorporated the reconstruction normalization into the pipeline in a new pull request #136. You can check it out to have reconstructions for better visualization |
Will give this a test, thank you! @lpanaf been using the conda compiled version of glomap https://prefix.dev/channels/conda-forge/packages/glomap, do you have any idea when a new release of glomap (1.0.1?) and colmap so that I can continue using this to avoid having to compile it myself? In the meantime I can use the source version |
In my case, Glomap detected 98/98 images when Colmap only detected 83/98 imagesLeft = Colmap 3.11dev0 commit Additional info:
Command used:
|
Colmap 3.11dev0 commit c238aec0 Glomap commit 98fa29a GLOMAP WINS |
Can anyone help me here? |
I've read multiple related issues #86 #123 #76 where glomap is not populating the sparse ponitcloud correctly. I assume this is the case for my issue as well.
versions:
sample:
commands:
mapper command:
a gsplat example:
The text was updated successfully, but these errors were encountered: