encoderd: ensure consistent frames per segment #34462
Open
+10
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deanlee
force-pushed
the
encoderd_ensure_frames_count_per_segment
branch
2 times, most recently
from
c2f7b8d to
95f34cf
Compare
deanlee
force-pushed
the
encoderd_ensure_frames_count_per_segment
branch
from
95f34cf to
69a037e
Compare
|
This PR has had no activity for 9 days. It will be automatically closed in 2 days if there is no activity. |
deanlee
force-pushed
the
encoderd_ensure_frames_count_per_segment
branch
from
69a037e to
a6d7f14
Compare
deanlee
force-pushed
the
encoderd_ensure_frames_count_per_segment
branch
from
a6d7f14 to
6eb3fa5
Compare
|
It's not clear what exactly should be done in this case. Let me think about it some more. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensures each segment contains exactly
SEGMENT_LENGTH * MAIN_FPSframes, even during camera re-alignment.It replaces the frame_id-based logic with a frame counter, guaranteeing consistent segment length regardless of camera re-alignment or frame ID jumps.