Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

camerad: match some BPS settings #34548

Merged
merged 13 commits into from
Feb 15, 2025
Merged

camerad: match some BPS settings #34548

merged 13 commits into from
Feb 15, 2025

Conversation

adeebshihadeh
Copy link
Contributor

@adeebshihadeh adeebshihadeh commented Feb 8, 2025

Seems the BPS shares a bunch of the same HW blocks as the IFE, so we can
share their configs. Differences so far:

shared:

  • demosaic
  • gamma
  • color space transform
  • vignetting correction

not shared:

  • white balance
  • black level
  • color correction

@ZwX1616 ZwX1616 marked this pull request as ready for review February 14, 2025 23:35
@ZwX1616 ZwX1616 changed the title camerad: match IFE and BPS settings camerad: match some BPS settings Feb 14, 2025
@ZwX1616
Copy link
Contributor

ZwX1616 commented Feb 14, 2025

let's merge this as is, and try to get binning in first?

@ZwX1616 ZwX1616 merged commit efda24d into master Feb 15, 2025
18 checks passed
@ZwX1616 ZwX1616 deleted the bpslooksmax branch February 15, 2025 00:05
Edison-CBS pushed a commit to Edison-CBS/openpilot that referenced this pull request Feb 15, 2025
* start common

* fix bayer pattern

* lil more

* all 1q10

* cc en

* same pts?

* this is weird

* some cleanup

* less

* off

* clean up

---------

Co-authored-by: Comma Device <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants