ui: Initial UI rewrite using pyray (spinner and text window) #34583
+327
−192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deanlee
force-pushed
the
pyray_init_version
branch
3 times, most recently
from
1d63cd9 to
49ec688
Compare
|
I have this artifact on the spinner texture |
adeebshihadeh
requested changes
Feb 14, 2025
resolved |
| self._view = rl.Rectangle() | ||
| self._show_vertical_scroll_bar: bool = show_vertical_scroll_bar | ||
|
|
||
| def handle_scroll(self)-> rl.Vector2: |
There was a problem hiding this comment.
scrolling with a wheel doesn't feel natural
Comment on lines
+52
to
+57
| rl.begin_scissor_mode(int(textarea_rect.x), int(textarea_rect.y), int(textarea_rect.width), int(textarea_rect.height)) | ||
| for i, line in enumerate(wrapped_lines): | ||
| position = rl.Vector2(textarea_rect.x + scroll.x, textarea_rect.y + scroll.y + i * LINE_HEIGHT) | ||
| rl.draw_text_ex(gui_app.font(), line.strip(), position, FONT_SIZE, 0, rl.WHITE) | ||
| rl.end_scissor_mode() |
There was a problem hiding this comment.
the text area tears while scrolling
There was a problem hiding this comment.
|
@maxime-desroches I propose switching to the official raylib library instead of our custom-built wheel on PC. This should help avoid the version 'GLIBC_2.38' not found issue. |
|
Already done - 9ccfecb |
deanlee
force-pushed
the
pyray_init_version
branch
from
3a302ae to
e265911
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The styles still need refinement, and additional improvements are required. However, this should be sufficient as an initial version to start with.