Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standard git merge commit messages #110

Closed
lstanc opened this issue Sep 6, 2024 · 1 comment
Closed

Standard git merge commit messages #110

lstanc opened this issue Sep 6, 2024 · 1 comment
Labels
duplicate This issue or pull request already exists question Further information is requested wontfix This will not be worked on

Comments

@lstanc
Copy link

lstanc commented Sep 6, 2024

Hi,

Maybe it would be nice to have such functionality that standard git merge commit messages are accepted by conventional-pre-commit as they are. By that I mean that they don't need to have "feat: " or the other prefixes. I think that would be good to add them as an exception to the validation rule. Below I'm placing example of such kind of message.
Example: commit message "Merge branch 'main' into feature/name-of-a-feature-branch".

@thekaveman thekaveman added duplicate This issue or pull request already exists question Further information is requested wontfix This will not be worked on labels Oct 8, 2024
@thekaveman
Copy link
Member

Thank you for the question @lstanc.

This has been discussed at length before, see: #19, #39, #76, #84.

TLDR; we are all about enforcing Conventional Commits formatting here. There are plenty of workarounds / alternate tools if you'd like to avoid this checking in certain scenarios.

@thekaveman thekaveman closed this as not planned Won't fix, can't repro, duplicate, stale Oct 8, 2024
@thekaveman thekaveman pinned this issue Oct 8, 2024
@compilerla compilerla locked as resolved and limited conversation to collaborators Oct 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
duplicate This issue or pull request already exists question Further information is requested wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants