Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ignore_binary_files should have the opposite value of detect_binary_files_with_prefix #293

Open
Hofer-Julian opened this issue Jan 17, 2025 · 2 comments
Labels
bug Something isn't working

Comments

@Hofer-Julian
Copy link

As one can see in the code, detect_binary_files_with_prefix is simply moved ignore_binary_files.

self._patch_move_new_path(
build_path, "/detect_binary_files_with_prefix", "/prefix_detection", "/ignore_binary_files"
)

What should happen instead is, that ignore_binary_files should be the opposite of detect_binary_files_with_prefix.

@Hofer-Julian Hofer-Julian added bug Something isn't working to sort Needs additional investigation labels Jan 17, 2025
@schuylermartin45 schuylermartin45 removed the to sort Needs additional investigation label Jan 17, 2025
@schuylermartin45 schuylermartin45 moved this from Backlog to Ready in Conda Recipe Manager Jan 17, 2025
@schuylermartin45
Copy link
Collaborator

To be clear, by "opposite" you mean the boolean logic needs to be flipped/negated?

@Hofer-Julian
Copy link
Author

To be clear, by "opposite" you mean the boolean logic needs to be flipped/negated?

Exactly :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Ready
Development

No branches or pull requests

2 participants