Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support ignore_run_exports_from in convert #298

Open
gforsyth opened this issue Jan 27, 2025 · 5 comments
Open

Support ignore_run_exports_from in convert #298

gforsyth opened this issue Jan 27, 2025 · 5 comments
Labels
enhancement New feature or request source::user-request Requests that come from the community and library users.

Comments

@gforsyth
Copy link

Description
Currently, a block like:

build:
  ignore_run_exports_from:
    - {{ compiler('cuda') }}

is copied directly over into a recipe.yaml file, but rattler-build doesn't support this syntax (https://rattler.build/latest/reference/recipe_file/#ignore-run-exports)

While rattler-build supports two different methods of specifying runtime ignores, one of them seems like a good direct analog to the conda-build format:

  requirements:
    build: ...
    ignore_run_exports:
      from_package:
        - {{ compiler('cuda') }}

Additional context

@gforsyth gforsyth added enhancement New feature or request source::user-request Requests that come from the community and library users. to sort Needs additional investigation labels Jan 27, 2025
@schuylermartin45 schuylermartin45 removed the to sort Needs additional investigation label Jan 27, 2025
@schuylermartin45
Copy link
Collaborator

I don't think I've seen this field (ignore_run_exports) before. I'm very happy you've pointed this out, it doesn't look like a direct translation is mentioned in CEP-13/CEP-14 that defines the new format.

I don't think this is difficult to add support for, it is just a matter of finding the time.

@jakirkham
Copy link
Member

Thanks Gil and Schuyler! 🙏

Just looking at the rattler-build docs, see the following advice:

  • build.ignore_run_exports is now requirements.ignore_run_exports.by_name
  • build.ignore_run_exports_from is now
    requirements.ignore_run_exports.from_package

When looking for that text in the CEPs, found the following in CEP 14:

  # the run exports to ignore when calculating the requirements
  ignore_run_exports:
    # ignore run exports by name (e.g. `libgcc-ng`)
    by_name: [string]
    # ignore run exports that come from the specified packages
    from_package: [string]

Maybe CEP 14 could clarify that better?

@schuylermartin45
Copy link
Collaborator

Most sections in the CEPs have a comment saying "this replaces X" or something similar. Certainly helps when you're in a rush and just Ctrl-F'ing through the file for the old field names.

@jakirkham
Copy link
Member

Yes this sounds like a good idea. Would you like to open a PR to the CEP?

@schuylermartin45
Copy link
Collaborator

I wouldn't mind doing it, but I won't be able to do that anytime soon. I have some very high priority tasks that are taking me away from the Conda community for a little bit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request source::user-request Requests that come from the community and library users.
Projects
Status: Ready
Development

No branches or pull requests

3 participants