Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows installer CLI option /S flag doesn't include any feedback #812

Closed
2 tasks done
pavelzw opened this issue Jun 25, 2024 · 1 comment · Fixed by #847
Closed
2 tasks done

Windows installer CLI option /S flag doesn't include any feedback #812

pavelzw opened this issue Jun 25, 2024 · 1 comment · Fixed by #847
Labels
type::bug describes erroneous operation, use severity::* to classify the type

Comments

@pavelzw
Copy link

pavelzw commented Jun 25, 2024

Checklist

  • I added a descriptive title
  • I searched open reports and couldn't find a duplicate

What happened?

When running the windows installer with /S, as expected, no installation GUI occurs. Instead, I would have expected that there is some feedback, for example the exit code.

Instead, the installer directly exits with exit code 0 and you have no way of knowing apart from opening Task Manager and searching for python or _conda or your installer running whether the installer is still running or has already finished.

For example, when providing an invalid path with /D, it doesn't fail but instead defaults to the default location.

I'm using conda-constructor via pixi global install constructor in an isolated environment.

Conda Info

No response

Conda Config

No response

Conda list

No response

Additional Context

No response

@pavelzw pavelzw added the type::bug describes erroneous operation, use severity::* to classify the type label Jun 25, 2024
@github-project-automation github-project-automation bot moved this to 🆕 New in 🧭 Planning Jun 25, 2024
@marcoesters
Copy link
Contributor

There are a few issues here that are separate from each other. I will try and address them one-by-one:

Instead, I would have expected that there is some feedback,

That would indeed be great to forward stdout into the console. I filed an issue in the past about this: #764

for example the exit code

As far as I'm aware, the exit code will always be 0, unfortunately. The logs are the best way to look for failures. However, log files have issues with installers in production because they write log files into %USERPROFILE% when a user hits the "Browse" button.

Instead, the installer directly exits with exit code 0 and you have no way of knowing apart from opening Task Manager and searching for python or _conda or your installer running whether the installer is still running or has already finished.

I assume you run the installer as installer.exe /S? If so, the command line just spawns the process that way without waiting for it. As far as I know, this is normal with calling exe files from cmd.exe. The way to run it is start /wait installer.exe /S.

For example, when providing an invalid path with /D, it doesn't fail but instead defaults to the default location.

This is unfortunately standard behavior of NSIS (the Windows installer backend of this project). Alternatives to NSIS have been looked at, but this is a more significant engineering effort to refactor and no solution is perfect: #646

Did that answer your questions?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type::bug describes erroneous operation, use severity::* to classify the type
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants