Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Leverage Jinja better #901

Closed
1 of 3 tasks
jaimergp opened this issue Nov 18, 2024 · 1 comment · Fixed by #922
Closed
1 of 3 tasks

Leverage Jinja better #901

jaimergp opened this issue Nov 18, 2024 · 1 comment · Fixed by #922
Assignees

Comments

@jaimergp
Copy link
Contributor

We were depending already on Jinja to parse the input file, so using it with our templates was a no brainer.

Some items:

  • Use Jinja for templating #892. This is the initial 1:1 conversion, not trying to be too smart to keep the diff digestable.
  • Move some simple templating logic like .lower() from the Python modules over to the Jinja template, where they belong
  • Replace some variables that render lots of lines with the corresponding for-loops in JInja
@michalwyszynski93
Copy link

examples/custom_nsis_template/custom.nsi.tmpl should also be changed to jinja

@marcoesters marcoesters self-assigned this Jan 6, 2025
@marcoesters marcoesters mentioned this issue Jan 6, 2025
3 tasks
@github-project-automation github-project-automation bot moved this from 🆕 New to 🏁 Done in 🧭 Planning Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🏁 Done
Development

Successfully merging a pull request may close this issue.

3 participants