-
Notifications
You must be signed in to change notification settings - Fork 640
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
--attach in create command #1805
Comments
Sure! thanks for offering. Please feel to work on it. |
The "container" and "task" below are referring to containerd concept: https://github.com/containerd/containerd/blob/main/docs/getting-started.md#creating-a-running-task --attach comes into effect in when creating new task today. https://github.com/containerd/nerdctl/blob/main/pkg/taskutil/taskutil.go#L43
The additional --attach information will be added to container struct in containerd and stored in container store. If --attach is also included in The only benefit I can think of adding --attach in Do you think it is good to add --attach in cc @AkihiroSuda as you reviewed the previous PR to add --attach in |
Do you mean add a new field to
That's also what I thought (since |
What is the problem you're trying to solve
Hi,
--attach
flag is indocker create
but not innerdctl create
.I'd like to contribute this change in nerdctl but I found
--attach
is not mentioned innerdctl create
documentation as "unimplemented flag". So before I make the change, just want to confirm that--attach
is an expected feature innerdctl create
and there is no implicit reason of not having --attach innerdctl create
intentionally.Describe the solution you'd like
Support
--attach
innerdctl create
.Additional context
https://docs.docker.com/engine/reference/commandline/create/#options
https://github.com/containerd/nerdctl#whale-blue_square-nerdctl-create
The text was updated successfully, but these errors were encountered: