Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Max zoom density setting #102

Open
ausi opened this issue Apr 22, 2024 · 6 comments
Open

Max zoom density setting #102

ausi opened this issue Apr 22, 2024 · 6 comments
Assignees
Labels

Comments

@ausi
Copy link
Member

ausi commented Apr 22, 2024

Currently if you have an image with a very small important part and an image size with a zoom level of 100% you will get very small images that will be shown blurry to the user as they will get upscaled by the browser.

It might make sense to add a setting for a minimum density that ensures that the zoom will stop as soon as the minimum density is reached. Possible names: zoomMinDensity, maxZoomDensity,…

/cc @Toflar

@ausi ausi added the feature label Apr 22, 2024
@ausi ausi self-assigned this Apr 22, 2024
@leofeyer
Copy link
Member

maxZoomDensity 👍

@aschempp
Copy link
Member

aschempp commented May 7, 2024

I my case such images would still be blown up by the browser to fix their div, that wouldn't change, would it?

@ausi
Copy link
Member Author

ausi commented May 7, 2024

I my case such images would still be blown up by the browser to fix their div, that wouldn't change, would it?

@aschempp Can you describe your case in more detail?
What does “to fix their div” mean?

@aschempp
Copy link
Member

I think with or height 100% is what I mean 😅

@ausi
Copy link
Member Author

ausi commented May 23, 2024

I think with or height 100% is what I mean 😅

👍

I my case such images would still be blown up by the browser to fix their div, that wouldn't change, would it?

@aschempp Can you describe your case in more detail?
This setting should prevent upscaling in the browser as it limits the maximum zoom level that can be applied and thus results in larger (more pixels) images. But as I don’t know anything about your case I’m not sure if this applies there.

@aschempp
Copy link
Member

I can't really, I was just thinking about the consequences. But the config makes sense (if I understand it correctly).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants