Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always Request Github Login if using Remote Config Server Url #3082

Closed
3 tasks done
lovenemesis opened this issue Nov 26, 2024 · 1 comment
Closed
3 tasks done

Always Request Github Login if using Remote Config Server Url #3082

lovenemesis opened this issue Nov 26, 2024 · 1 comment
Assignees
Labels
area:configuration Relates to configuration options ide:vscode Relates specifically to VS Code extension kind:bug Indicates an unexpected problem or unintended behavior

Comments

@lovenemesis
Copy link

Before submitting your bug report

Relevant environment info

- OS: Fedora 41
- Continue version: v0.8.59 and v0.9.235
- IDE version: VSCodium 1.95.3
- Model: Self-hosted Qwen2.5-coder
- config.json:

Description

Whenever the Remote Config Server URL is configured, starting VSCodium will trigger a pop-up asking signing using Github.

Screenshot From 2024-11-26 15-24-56

Although it appears to be something that can be safely ignored as the remote server configuration works anyway, it's a bit annoying to have to click Cancel when starting VSCodium.

This applies both to VS Code and VS Codium, but not the Android Studio which on v0.0.81. Putting Remote Config Server URL there will NOT trigger the signing pop-up.

To reproduce

  1. Go to Settings and put a URL pointing to the server holding remote configuration file.
  2. Restart VSCodium

Log output

workbench.desktop.main.js:35  WARN Settings pattern "issueReporter.*" doesn't match any settings
workbench.desktop.main.js:35  INFO Started local extension host with pid 74910.
workbench.desktop.main.js:35  WARN Settings pattern "issueReporter.*" doesn't match any settings
workbench.desktop.main.js:35  INFO [perf] Render performance baseline is 42ms
workbench.desktop.main.js:613 [Extension Host] rejected promise not handled within 1 second: Error: User did not consent to login.
gqi @ workbench.desktop.main.js:613
workbench.desktop.main.js:613 [Extension Host] stack trace: Error: User did not consent to login.
    at j5t.doGetSession (vscode-file://vscode-app/usr/share/codium/resources/app/out/vs/workbench/workbench.desktop.main.js:649:74479)
    at async j5t.$getSession (vscode-file://vscode-app/usr/share/codium/resources/app/out/vs/workbench/workbench.desktop.main.js:649:75431)
gqi @ workbench.desktop.main.js:613
workbench.desktop.main.js:35   ERR User did not consent to login.: Error: User did not consent to login.
    at j5t.doGetSession (vscode-file://vscode-app/usr/share/codium/resources/app/out/vs/workbench/workbench.desktop.main.js:649:74479)
    at async j5t.$getSession (vscode-file://vscode-app/usr/share/codium/resources/app/out/vs/workbench/workbench.desktop.main.js:649:75431)
@sestinj sestinj self-assigned this Nov 26, 2024
@dosubot dosubot bot added area:configuration Relates to configuration options ide:vscode Relates specifically to VS Code extension kind:bug Indicates an unexpected problem or unintended behavior labels Nov 26, 2024
@sestinj
Copy link
Contributor

sestinj commented Nov 27, 2024

@lovenemesis We fall back to GitHub authentication if you don't have a userToken defined. As long as you set the "User Token" value we won't request GitHub auth. Given that API keys are likely to be obtained through a remote server URL, we won't adding an option to remove authentication

Source code is here for reference: https://github.com/continuedev/continue/blob/ad298878cc6a00ffe32a54b80efc7ced20782ed2/extensions/vscode/src/stubs/auth.ts#L4-L17

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:configuration Relates to configuration options ide:vscode Relates specifically to VS Code extension kind:bug Indicates an unexpected problem or unintended behavior
Projects
None yet
Development

No branches or pull requests

2 participants