Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] ArrowAnnotateTool doesn't emit annotation modified on the initial draw #1791

Open
JamesAPetts opened this issue Jan 31, 2025 · 0 comments
Assignees
Labels
bugs Something isn't working, verified by maintainers

Comments

@JamesAPetts
Copy link
Member

JamesAPetts commented Jan 31, 2025

Describe the Bug

This method needs to emit annotation modified:

_dragCallback = (evt: EventTypes.InteractionEventType): void => {

Also when finishing a new annotation, only completed is fired, so modified is never fired at all other than on the initial click:

this.configuration.getTextCallback((text) => {

Steps to Reproduce

  • Set up a handler to track measurement modified events.
  • Draw a new ArrowAnnotateTool annotation.
  • Notice an event is only fired at the start, not during moving the arrow, or at finish the arrow.

The current behavior

  • Annotation modified events aren't being fired on initial draw whilst modifying the annotation.
  • Note that we do emit events when modifying it after initial draw.

The expected behavior

  • ArrowAnnotate tool should emit events whilst drawing, so that the final state when you finish drawing can be tracked by consumers.

OS

N/A any

Node version

N/A any

Browser

N/A any

@sedghi sedghi added the bugs Something isn't working, verified by maintainers label Feb 4, 2025 — with Linear
@linear linear bot assigned sedghi and unassigned IbrahimCSAE Feb 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugs Something isn't working, verified by maintainers
Projects
None yet
Development

No branches or pull requests

3 participants